atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Re: Review Request 69925: Removed hard-code Use of QualifiedName as Attribute
Date Fri, 08 Feb 2019 18:56:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69925/
-----------------------------------------------------------

(Updated Feb. 8, 2019, 6:56 p.m.)


Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

Updates include: Addressed review comments.


Bugs: ATLAS-3048
    https://issues.apache.org/jira/browse/ATLAS-3048


Repository: atlas


Description
-------

Using _EntityType.getUniqueAttributes_ to get attributes.


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java
628c1cc4b 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociatorTest.java
16074b63c 
  repository/src/test/resources/json/classification-association/col-entity-def-unique-name.json
PRE-CREATION 
  repository/src/test/resources/json/classification-association/header-PII-no-qualifiedName.json
PRE-CREATION 


Diff: https://reviews.apache.org/r/69925/diff/2/

Changes: https://reviews.apache.org/r/69925/diff/1-2/


Testing
-------

**Unit tests**
Added unit tests.


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message