atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (ATLAS-3116) Fix LDAP login, once a sign-on is made through knox SSO.
Date Tue, 09 Apr 2019 09:21:00 GMT


ASF subversion and git services commented on ATLAS-3116:

Commit 7e86cb30841b1ff9683fd121e3f8a17d2638e6e8 in atlas's branch refs/heads/branch-1.0 from
Nixon Rodrigues
[;h=7e86cb3 ]

ATLAS-3116:- Changed bean scope to prototype to fix LDAP login, once a sign-on is made through
knox SSO.

Change-Id: Ia76852d1c4e13216c54d225e0cbcd1108fd2f402

> Fix LDAP login, once a sign-on is made through knox SSO.
> --------------------------------------------------------
>                 Key: ATLAS-3116
>                 URL:
>             Project: Atlas
>          Issue Type: Bug
>    Affects Versions: 0.8.3, 1.1.0
>            Reporter: Nixon Rodrigues
>            Assignee: Nixon Rodrigues
>            Priority: Major
>             Fix For: 0.8.4, 1.2.0, 2.0.0
>         Attachments: ATLAS-3116.patch
> *Background of the issue.*
> Dependency of AtlasAuthenticationProvider is Injected in two place from constructor with
@Inject 1) [AtlasKnoxSSOFilter|] and [AtlasSecurityConfig|].
> After observing the hashCode of objects of the AtlasAuthenticationProvider appeared to
be same in respectively classes.
> If no scope is specified single instance per container is created and thats caused the
bug described below.
> The *ssoEnabled* is a property in AtlasAuthenticationProvider which set from AtlasKnoxSSOFilter
flow. Since the object reference were same, once the ssoEnabled is set true,  it apply for
LdapAuthentication flow also and the [ldap authentication flow is goes in sso block|]
> To fix the issue added scope prototype to AtlasAuthenticationProvider , so that different
objects are create in AtlasKnoxSSOFilter and AtlasSecurityConfig respectively.

This message was sent by Atlassian JIRA

View raw message