atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 71726: ATLAS-3510: Enable quick-search and suggestions on entity labels
Date Wed, 06 Nov 2019 16:29:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71726/#review218548
-----------------------------------------------------------



It would help if there is a unit test for this.

- Ashutosh Mestry


On Nov. 6, 2019, 7:04 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71726/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2019, 7:04 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan
Neethiraj, mayank jain, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3510
>     https://issues.apache.org/jira/browse/ATLAS-3510
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Searching on label name in quicksearch box doesn't return entities matching label names.
This should follow the same behavior of classification name search in quick search
> 
> 
> Solution:
> 
> label and user-defined properties are specially added manually when registering search-weights
using solr-client
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 73108617c

>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
7853dc15c 
> 
> 
> Diff: https://reviews.apache.org/r/71726/diff/2/
> 
> 
> Testing
> -------
> 
> Mamnually validated quick search and suggestions yields right result.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message