atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Le Ma <constance.m...@gmail.com>
Subject Re: Review Request 71736: ATLAS-3482 Enhance basic search to enable search on entity system attributes
Date Thu, 14 Nov 2019 23:57:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71736/
-----------------------------------------------------------

(Updated Nov. 14, 2019, 11:57 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and
Sarath Subramanian.


Changes
-------

Resolve comments.


Bugs: ATLAS-3482
    https://issues.apache.org/jira/browse/ATLAS-3482


Repository: atlas


Description
-------

Introduce ALL_ENTITY_TYPE to support search on system attributes across all entity types.
System attributes will be passed in as normal entity attributes.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 8f0e5912d 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java e10965b87 
  intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ed1e5ded2 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 417194202 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 884447f81 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e8bf7f9eb 
  intg/src/main/java/org/apache/atlas/type/Constants.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 672f38132

  repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 03eb92bcc

  repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 152ade8d4

  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 7ad32bdb9 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java b56d8e83a 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
7c551304b 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 825cda30b 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java cd8f8981c 


Diff: https://reviews.apache.org/r/71736/diff/3/

Changes: https://reviews.apache.org/r/71736/diff/2-3/


Testing
-------

- Added new unit tests, passed.
- will run pre-commit job.


Thanks,

Le Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message