atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry via Review Board <nore...@reviews.apache.org>
Subject Review Request 71795: DSL Queries: LIKE Clause with Special Characters
Date Wed, 20 Nov 2019 21:52:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71795/
-----------------------------------------------------------

Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-3520
    https://issues.apache.org/jira/browse/ATLAS-3520


Repository: atlas


Description
-------

**Background**
Please refer to the bug description for details.

**Approach**
- Detect special chacters in the right-hand-side of LIKE clause.
- Use textRegex instead of textContainsRegex.


Diffs
-----

  repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 294dc00e5 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 724ae9f7a 
  repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java ca32ffc99



Diff: https://reviews.apache.org/r/71795/diff/1/


Testing
-------

**Unit tests**
- _DSLQueriesTest_ updated to handle this case.
- _GremlinQueryComposerTest_ updated to handle this case.

**Functional tests**
Via UI.


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message