atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 71796: ATLAS-3530: Retrieve entityDefinition for '_ALL_ENTITY_TYPES' in /api/atlas/v2/types/entitydef/name/{name}
Date Thu, 21 Nov 2019 22:44:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71796/#review218748
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
Lines 264 (patched)
<https://reviews.apache.org/r/71796/#comment306622>

    Remove ignore case?


- Ashutosh Mestry


On None, Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71796/
> -----------------------------------------------------------
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan
Neethiraj, Mandar Ambawane, Nikhil Bonte, Nixon Rodrigues, Sameer Shaikh, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3530
>     https://issues.apache.org/jira/browse/ATLAS-3530
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> '_ALL_ENTITY_TYPES' is a new system type with all system attributes of an entity in ATLAS-3482.
> 
> A new TypesREST endpoint to retrieve definition of '_ALL_ENTITY_TYPES' is necessary to
render system attributes in UI.
> 
> GET /api/atlas/v2/types/entitydef/name/ALL_ENTITY_TYPES should return entityDef.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 557ef74a9 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
2e2ab1a66 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java
51dd16b85 
> 
> 
> Diff: https://reviews.apache.org/r/71796/diff/1/
> 
> 
> Testing
> -------
> 
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/
> 
> Added unit test to check if 'ALL_ENTITY_TYPES' definition is returned correctly.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message