atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 72994: ATLAS-4010: Sort properties lexicographically in pom.xml for readability
Date Mon, 02 Nov 2020 06:07:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/#review222154
-----------------------------------------------------------




distro/pom.xml
Line 51 (original), 39 (patched)
<https://reviews.apache.org/r/72994/#comment311220>

    avoid extra spaces in lines 39-60. These properties are written to conf file and may be
written with intendation.



distro/pom.xml
Line 346 (original), 333 (patched)
<https://reviews.apache.org/r/72994/#comment311221>

    avoid extra spaces in lines 333-337



distro/pom.xml
Line 425 (original), 412 (patched)
<https://reviews.apache.org/r/72994/#comment311222>

    avoid extra spaces in lines 412-421


- Sarath Subramanian


On Oct. 30, 2020, 10:46 a.m., Radhika Kundam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72994/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2020, 10:46 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-4010
>     https://issues.apache.org/jira/browse/ATLAS-4010
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Properties are in random order under <properties> section in pom.xml
> 
> For better readability, need to sort properties in lexicographic order.
> 
> 
> Diffs
> -----
> 
>   distro/pom.xml db1f23acd 
>   docs/pom.xml f22f9e2ff 
>   pom.xml aca36aaee 
>   webapp/pom.xml 5a8cfe616 
> 
> 
> Diff: https://reviews.apache.org/r/72994/diff/1/
> 
> 
> Testing
> -------
> 
> Build is successful.
> 
> 
> File Attachments
> ----------------
> 
> Removing extra spaces
>   https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch
> 
> 
> Thanks,
> 
> Radhika Kundam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message