atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes
Date Wed, 04 Nov 2020 02:35:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/
-----------------------------------------------------------

(Updated Nov. 4, 2020, 2:35 a.m.)


Review request for atlas, Nikhil Bonte and Sarath Subramanian.


Changes
-------

Updates include: Addressed review comments.


Bugs: ATLAS-4006 and ATLAS-4007
    https://issues.apache.org/jira/browse/ATLAS-4006
    https://issues.apache.org/jira/browse/ATLAS-4007


Repository: atlas


Description
-------

**Background**
Existing implementation does not support export and import of _Business Metadata_ (BM) attributes.


**Implementation**
- Export: Updated existing flow to include detecting BM attributes and adding the types to
the exported payload.
- Import: Updated _TypeAttributeDifference_ to include BM attribute detection and update.


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 0491a853a

  repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java 664af9166

  repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
b65807742 
  repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
0d78dbe57 
  repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
f9b7cd11f 
  repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72991/diff/2/

Changes: https://reviews.apache.org/r/72991/diff/1-2/


Testing
-------

**Unit tests**
New tests added.

**Functional testing**
End-to-end tests. (Export-import-export).

**Pre-commit Build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/


File Attachments (updated)
----------------

Stocks with BM
  https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message