-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73000/
-----------------------------------------------------------
(Updated Nov. 5, 2020, 5:48 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Removed the `mkdir data` instruction from the README file. During testing I found that if
the data directory isn't present on host machine, its created during the `docker run` command
without user requiring to create it. So that instruction in README file isn't required.
Bugs: ATLAS-4011
https://issues.apache.org/jira/browse/ATLAS-4011
Repository: atlas
Description
-------
- Mounting data directory from host machine into $ATLAS_HOME/data
- To ensure solr collections are created in the data directory, setting the SOLR_HOME using
-s option. Also, copying solr.xml from the solr installation directory to the solr home
- Changed the command to keep the container from exiting when the container runs in a pod
in Kubernetes
- Updated the documentation with new command for running docker container
Diffs (updated)
-----
dev-support/atlas-docker/Dockerfile.atlas e2dea7716
dev-support/atlas-docker/README.md de644472b
dev-support/atlas-docker/docker-compose.atlas.yml 92bd1edd0
dev-support/atlas-docker/scripts/atlas.sh 0c4a4546a
distro/src/bin/atlas_config.py bda8e2a10
distro/src/bin/atlas_start.py 54fd2bd47
distro/src/bin/atlas_stop.py 400a7d23d
distro/src/test/python/scripts/TestMetadata.py f1235f747
Diff: https://reviews.apache.org/r/73000/diff/2/
Changes: https://reviews.apache.org/r/73000/diff/1-2/
Testing
-------
1. Built the atlas container using `docker build -f Dockerfile.atlas --build-arg ATLAS_VERSION=3.0.0-SNAPSHOT
-t atlas .`
2. Ran the atlas container using `docker run -it -d --name atlas --hostname localhost -p 21000:21000
-v $PWD/data:/home/atlas/data atlas`
3. Atlas was up and running, created some entities
4. Restarted the container. The entites created in step 3, were still there
5. Deleted the container using `docker rm -f atlas`
6. Created the conatiner again using the same command in step 2. The entities created in step
3 were present.
Thanks,
Jayendra Parab
|