atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jayendra Parab <jayendra.pa...@gmail.com>
Subject Re: Review Request 73000: ATLAS-4011: While running Atlas Docker container, data should be stored on host
Date Thu, 05 Nov 2020 05:55:12 GMT


> On Nov. 2, 2020, 7:09 p.m., Madhan Neethiraj wrote:
> > dev-support/atlas-docker/README.md
> > Lines 42 (patched)
> > <https://reviews.apache.org/r/73000/diff/1/?file=2241770#file2241770line42>
> >
> >     Instead of requiring users to create directory 'data', I suggest to create this
directory and include with this patch. Please make sure to commit  .gitignore file in this
directory.
> >     
> >     Once this is done, please remove 4.2 and 5.5.

The explicit `mkdir data` step isn't required at all since docker creates the directory during
the `docker run` command. So, we don't need to commit the data directory. The user can also
choose any other directory for storing the data.
Updated the README file with these changes.


- Jayendra


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73000/#review222158
-----------------------------------------------------------


On Nov. 5, 2020, 5:48 a.m., Jayendra Parab wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73000/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2020, 5:48 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath
Subramanian.
> 
> 
> Bugs: ATLAS-4011
>     https://issues.apache.org/jira/browse/ATLAS-4011
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - Mounting data directory from host machine into $ATLAS_HOME/data
> - To ensure solr collections are created in the data directory, setting the SOLR_HOME
using -s option. Also, copying solr.xml from the solr installation directory to the solr home
> - Changed the command to keep the container from exiting when the container runs in a
pod in Kubernetes
> - Updated the documentation with new command for running docker container
> 
> 
> Diffs
> -----
> 
>   dev-support/atlas-docker/Dockerfile.atlas e2dea7716 
>   dev-support/atlas-docker/README.md de644472b 
>   dev-support/atlas-docker/docker-compose.atlas.yml 92bd1edd0 
>   dev-support/atlas-docker/scripts/atlas.sh 0c4a4546a 
>   distro/src/bin/atlas_config.py bda8e2a10 
>   distro/src/bin/atlas_start.py 54fd2bd47 
>   distro/src/bin/atlas_stop.py 400a7d23d 
>   distro/src/test/python/scripts/TestMetadata.py f1235f747 
> 
> 
> Diff: https://reviews.apache.org/r/73000/diff/2/
> 
> 
> Testing
> -------
> 
> 1. Built the atlas container using `docker build -f Dockerfile.atlas --build-arg ATLAS_VERSION=3.0.0-SNAPSHOT
-t atlas .`
> 2. Ran the atlas container using `docker run -it -d --name atlas --hostname localhost
-p 21000:21000 -v $PWD/data:/home/atlas/data atlas`
> 3. Atlas was up and running, created some entities
> 4. Restarted the container. The entites created in step 3, were still there
> 5. Deleted the container using `docker rm -f atlas`
> 6. Created the conatiner again using the same command in step 2. The entities created
in step 3 were present.
> 
> 
> Thanks,
> 
> Jayendra Parab
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message