-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73007/#review222176
-----------------------------------------------------------
authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java
Lines 37 (patched)
<https://reviews.apache.org/r/73007/#comment311239>
consider moving the new enum value 'ADMIN_AUDITS' to the end (after line 49) to avoid
messing with enum ordinal
- Sarath Subramanian
On Nov. 9, 2020, 7:40 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73007/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2020, 7:40 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath
Subramanian.
>
>
> Bugs: ATLAS-4016
> https://issues.apache.org/jira/browse/ATLAS-4016
>
>
> Repository: atlas
>
>
> Description
> -------
>
> For Atlas Admin Audits we need to add new privilege - "admin-audits" for authorization
>
> Similar permission needs to be updated in ranger atlas service-def.
>
>
> Diffs
> -----
>
> authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 9dbcd32
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java f6a20c0
>
>
> Diff: https://reviews.apache.org/r/73007/diff/1/
>
>
> Testing
> -------
>
> Testing is done on the cluster with Atlas and Ranger services running.
>
> First, When only Atlas side changes are applied on cluster and then Admin tries to access
the Admin Audits, It gets an Authorization error 403. Which is expected.
>
> Then after applying Ranger side changes on cluster, Admin could successfully access the
Admin Audits.
>
>
> Thanks,
>
> Mandar Ambawane
>
>
|