avro-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From th...@apache.org
Subject svn commit: r1186614 - in /avro/trunk: CHANGES.txt lang/c++/api/Decoder.hh lang/c++/api/Encoder.hh lang/c++/test/CodecTests.cc
Date Thu, 20 Oct 2011 04:50:03 GMT
Author: thiru
Date: Thu Oct 20 04:50:03 2011
New Revision: 1186614

URL: http://svn.apache.org/viewvc?rev=1186614&view=rev
Log:
AVRO-938. Some more warning when built on RHEL

Modified:
    avro/trunk/CHANGES.txt
    avro/trunk/lang/c++/api/Decoder.hh
    avro/trunk/lang/c++/api/Encoder.hh
    avro/trunk/lang/c++/test/CodecTests.cc

Modified: avro/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/avro/trunk/CHANGES.txt?rev=1186614&r1=1186613&r2=1186614&view=diff
==============================================================================
--- avro/trunk/CHANGES.txt (original)
+++ avro/trunk/CHANGES.txt Thu Oct 20 04:50:03 2011
@@ -148,6 +148,8 @@ Avro 1.6.0 (unreleased)
 
     AVRO-918. Avro C++ documentation is very old. (thiru)
 
+    AVRO-938. Some more warning when built on RHEL. (thiru)
+
   BUG FIXES
 
     AVRO-824. Java: Fix usage message of BinaryFragmentToJsonTool.

Modified: avro/trunk/lang/c++/api/Decoder.hh
URL: http://svn.apache.org/viewvc/avro/trunk/lang/c%2B%2B/api/Decoder.hh?rev=1186614&r1=1186613&r2=1186614&view=diff
==============================================================================
--- avro/trunk/lang/c++/api/Decoder.hh (original)
+++ avro/trunk/lang/c++/api/Decoder.hh Thu Oct 20 04:50:03 2011
@@ -47,6 +47,7 @@ namespace avro {
  */
 class Decoder {
 public:
+    virtual ~Decoder() { };
     /// All future decoding will come from is, which should be valid
     /// until replaced by another call to init() or this Decoder is
     /// destructed.

Modified: avro/trunk/lang/c++/api/Encoder.hh
URL: http://svn.apache.org/viewvc/avro/trunk/lang/c%2B%2B/api/Encoder.hh?rev=1186614&r1=1186613&r2=1186614&view=diff
==============================================================================
--- avro/trunk/lang/c++/api/Encoder.hh (original)
+++ avro/trunk/lang/c++/api/Encoder.hh Thu Oct 20 04:50:03 2011
@@ -51,6 +51,7 @@ namespace avro {
  */
 class Encoder {
 public:
+    virtual ~Encoder() { };
     /// All future encodings will go to os, which should be valid until
     /// it is reset with another call to init() or the encoder is
     /// destructed.

Modified: avro/trunk/lang/c++/test/CodecTests.cc
URL: http://svn.apache.org/viewvc/avro/trunk/lang/c%2B%2B/test/CodecTests.cc?rev=1186614&r1=1186613&r2=1186614&view=diff
==============================================================================
--- avro/trunk/lang/c++/test/CodecTests.cc (original)
+++ avro/trunk/lang/c++/test/CodecTests.cc Thu Oct 20 04:50:03 2011
@@ -347,6 +347,7 @@ static vector<string>::const_iterator sk
 static void check(Decoder& d, unsigned int skipLevel,
     const char* calls, const vector<string>& values)
 {
+    const size_t zero = 0;
     Scanner sc(calls);
     stack<StackElement> containerStack;
     vector<string>::const_iterator it = values.begin();
@@ -465,7 +466,7 @@ static void check(Decoder& d, unsigned i
                 const StackElement& se = containerStack.top();
                 BOOST_CHECK_EQUAL(se.size, se.count);
                 if (se.size != 0) {
-                    BOOST_CHECK_EQUAL(0, d.arrayNext());
+                    BOOST_CHECK_EQUAL(zero, d.arrayNext());
                 }
                 containerStack.pop();
             }
@@ -475,7 +476,7 @@ static void check(Decoder& d, unsigned i
                 const StackElement& se = containerStack.top();
                 BOOST_CHECK_EQUAL(se.size, se.count);
                 if (se.size != 0) {
-                    BOOST_CHECK_EQUAL(0, d.mapNext());
+                    BOOST_CHECK_EQUAL(zero, d.mapNext());
                 }
                 containerStack.pop();
             }



Mime
View raw message