axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chinthana Danapala (JIRA)" <axis-c-...@ws.apache.org>
Subject [jira] Created: (AXISCPP-410) Best Practices in code
Date Tue, 08 Feb 2005 10:28:11 GMT
Best Practices in code
----------------------

         Key: AXISCPP-410
         URL: http://issues.apache.org/jira/browse/AXISCPP-410
     Project: Axis-C++
        Type: Improvement
  Components: Client - Engine  
    Versions: 1.5 Alpha    
    Reporter: Chinthana Danapala
    Priority: Trivial


I’m going through the code and I found some best practices we need to be apply.

1.ApacheTransport.cpp

	ApacheTransport::ApacheTransport(void* pContext)
	{
		-------
		------
		m_pContext = pContext;

		*this is just a soft copy it should be make hard coppy for best practice.
	}

	const char* ApacheTransport::getTransportProperty(AXIS_TRANSPORT_INFORMATION_TYPE eType)
	{
		const char* pcValue;
		*BP: assign NULL when diclare it.
	}
	
	const char* ApacheTransport::getTransportProperty(const char* pcKey)
	{
		array_header* arr;
		*BP: assign NULL when diclare it
	}

2. Axis.cpp
	
	HandlerLoader* g_pHandlerLoader;
	AppScopeHandlerPool* g_pAppScopeHandlerPool;
	RequestScopeHandlerPool* g_pRequestScopeHandlerPool;
	SessionScopeHandlerPool* g_pSessionScopeHandlerPool;
	DeserializerPool* g_pDeserializerPool;
	SerializerPool* g_pSerializerPool;
	HandlerPool* g_pHandlerPool;
	// Unsynchronized read-only global variables.
	WSDDDeployment* g_pWSDDDeployment;
	AxisConfig* g_pConfig;
	
	*BP: assign NULL when diclare it

	STORAGE_CLASS_INFO int process_request(SOAPTransport* pStream)
	{
		FILE* WsddFile;       *BP: assign NULL when diclare it
	}	

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message