axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Samisa Abeysinghe <samisa.abeysin...@gmail.com>
Subject Re: [AXIS2] Suggestion for change in coding convention
Date Fri, 04 Nov 2005 06:17:35 GMT
Damitha Kumarage wrote:

> nandika jayawardana wrote:
>
>> Hi all,
>> For formating function signature , can we use the follwing formatting
>>
>> eg
>>
>> axis2_status_t AXIS2_CALL
>> axis2_om_node_set_parent(axis2_om_node_t *om_node,
>>                                          axis2_env_t **env,
>>                                          axis2_om_node_t *parent);
>>
>> This will make the code look more consistent,
>>
>> pls comment in this ......
>>
>> regards ..
>> nandika
>>
>>
> This is cool. In addition for function pointers I prefer the following
>
> axis2_status_t (AXIS2_CALL *add_param) (axis2_param_container_t 
> *param_container,
>                             axis2_env_t **env,
>                             axis2_param_t *param);

IMHO, it is more readable to have the parameters aligned like the folowing.
axis2_status_t (AXIS2_CALL *add_param) (axis2_param_container_t 
*param_container,
                                                                        
axis2_env_t **env,
                                                                        
axis2_param_t *param);

Samisa...

>
> instead of
>
> axis2_status_t
> (AXIS2_CALL *add_param)(axis2_param_container_t *param_container,
>
> or
>
> axis2_status_t  (AXIS2_CALL
> *add_param)(axis2_param_container_t *param_container,
>
> damitha
>                               



Mime
View raw message