axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duane Murphy (JIRA)" <axis-c-...@ws.apache.org>
Subject [jira] Created: (AXISCPP-870) IChannel operator >>() should not have const parameter.
Date Thu, 10 Nov 2005 19:04:05 GMT
IChannel operator >>() should not have const parameter.
-------------------------------------------------------

         Key: AXISCPP-870
         URL: http://issues.apache.org/jira/browse/AXISCPP-870
     Project: Axis-C++
        Type: Improvement
  Components: Transport (axis3)  
    Versions: 1.5 Final    
    Reporter: Duane Murphy


The function signature

    virtual const IChannel&		operator >> (const char * msg)=0;

from IChannel.h should not have the parameter be const. The correct signature should be:

    virtual const IChannel&		operator >> (char * msg)=0;

Input streaming operators are non-const. The value of msg will be overwritten by the operator
by definition.  This function is implemented by casting away const.

Note: this functions signature is also used in the axis2 IChannel interface.

Note: that this function is inherently dangerous as it assumes that msg points to at least
BUF_SIZE storage. Using a std::string or std::vector<char> would be a better choice.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message