axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Damitha Kumarage <>
Subject Re: [Axis2] [Patch] Cleaning up
Date Wed, 07 Dec 2005 03:13:14 GMT
Hi Anuradha,

Anuradha Ratnaweera wrote:

>Hi all,
>I finally got make dist working!  But it needed a lot of
>`improvements' all over the place.  This is the first set of them, and
>they are for the file.  Here is an un-summary of changes:
>(summarizing is shortening, and the explainations below are _bigger_
>than actual code changes, so I am calling it an un-summary ;-) ).
>- Changed the order of doing things to match the order
>- AC_INIT and AM_INIT_AUTOMAKE gets the package name properly (without
>this, make dist fails.  Check for PACKAGE= and VERSION= values in
>Makefile without them)
>- Removed AC_CONFIG_AUX_DIR.  It is to be used for a different reason
>which we don't need here.  make dist doesn't work without this change.
> The directory conftools can go away from SVN too.
>- Removed AC_PROG_LIBTOOL (one AM_PROG_LIBTOOL is enough)
>- Replaced LDFLAGS setting with a test (AC_CHECK_LIB) for cutest
I had a plan to remove cutest from LDFLAGS because then main module is 
link wise
independant of cutest. Cutest is needed for only unit tests which is not 
included in
the source build.  To build unit tests we need to go into the c/test 
folder and make it.
So testing for cutest in is not required.
So shall we remove checking for cutest?

>- Removed setting LIBS to -ldl, because AC_CHECK_LIB automatically sets that
>- Changed # to dnl everywhere (standard practice)
>I have attached both the patch and itself.  I don't think
>it _breaks_ anything, but mostly rearranging and removing.
>        Anuradha
>---	(revision 354402)
>+++	(working copy)
>@@ -1,40 +1,38 @@
>-# run to generate the configure script.
>+dnl run to generate the configure script.
> AC_PREREQ(2.59)
> AC_INIT(axis2, 1.0.0)
>-# Checks for programs.
>+dnl Checks for programs.
>-# Checks for libraries.
>+dnl Checks for libraries.
> AC_CHECK_LIB(dl, dlopen)
>+AC_CHECK_LIB(cutest, CuTestInit)
>-#using libtool
> CFLAGS="$CFLAGS -ansi -Wall -D_LARGEFILE64_SOURCE -g3 -O2"
-g -O2 -pthread"
>-# Checks for header files.
>+dnl Checks for header files.
> AC_CHECK_HEADERS([stdio.h stdlib.h string.h])
>-# Checks for typedefs, structures, and compiler characteristics.
>+dnl Checks for typedefs, structures, and compiler characteristics.
>-# Checks for library functions.
>+dnl Checks for library functions.
> #AC_CHECK_FUNCS([memmove])

View raw message