axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emanuel Norrbin (JIRA)" <axis-c-...@ws.apache.org>
Subject [jira] Created: (AXISCPP-922) Resource leak in AttachmentHelper::extract_Attachment
Date Thu, 26 Jan 2006 01:37:09 GMT
Resource leak in AttachmentHelper::extract_Attachment
-----------------------------------------------------

         Key: AXISCPP-922
         URL: http://issues.apache.org/jira/browse/AXISCPP-922
     Project: Axis-C++
        Type: Bug
  Components: Server - Deserialization  
    Versions:  1.6 Final    
 Environment: All platforms, this issue was found in nightly drop 24-Jan-2006 21:23 
    Reporter: Emanuel Norrbin


File: server\apache2\AttachmentHelper.cpp
Method: void AttachmentHelper::extract_Attachment(char *pBuffer)
Line: 88 - 89

This is a very easy bug to spot and fix:

            xsd__base64Binary*  base64_attachment = new xsd__base64Binary();
            base64_attachment = AxisUtils::decodeFromBase64Binary(attach);		

In Java this code would be fine but in C++ is is a resource leak,
the first new is not needed since decodeFromBase64Binary will allocate the xsd__base64Binary.
I suggest replacing the two lines with this one:

xsd__base64Binary*  base64_attachment = AxisUtils::decodeFromBase64Binary(attach);

/Emanuel


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message