axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dinesh Premalal <dinesh.prema...@cse.mrt.ac.lk>
Subject Re: [Axis2]Guththila should be re organized[Fwd: svn commit: r393763 - /webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c]
Date Fri, 14 Apr 2006 03:10:02 GMT
Hi,
>     We also have a well tested hash map and array list structures that
> could be used by Guththila.
   This would make our life easier, because guththila_stack seems to lead lot
of memory leaks. Since Axis2/c has hash map and array list Ill be able to use it to replace
guththila_stack code. Hope that array list and hash map doesn't have any external 
dependencies. 
>     Please have a look into the source of the util module to get a
> gauge on the improvements.
Ill look on that code.Thanks for the pointer.

cheers,
Dinesh
> 
> Thanks,
> Samisa...
> 
> 
> -------- Original Message --------
> Subject: 	svn commit: r393763 -
> /webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c
> Date: 	Thu, 13 Apr 2006 08:46:21 -0000
> From: 	dinesh@apache.org
> To: 	axis2-cvs@ws.apache.org
> 
> 
> 
> Author: dinesh
> Date: Thu Apr 13 01:46:19 2006
> New Revision: 393763
> 
> URL: http://svn.apache.org/viewcvs?rev=393763&view=rev
> Log:
> guththila_stack_free () tends to memory leaks when there are no elements
> 
> Modified:
>     webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c
> 
> Modified: webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c
> URL: http://svn.apache.org/viewcvs/webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c?rev=393763&r1=393762&r2=393763&view=diff
> ==============================================================================
> --- webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c
(original)
> +++ webservices/axis2/trunk/c/modules/xml/parser/guththila/impl/src/guththila_stack.c
Thu Apr 13 01:46:19 2006
> @@ -91,11 +91,13 @@
>                        guththila_stack_t * stack)
>  {
>      if (stack && (stack->pointer > 0))
> -    {
> +      {
>          guththila_element_t *ele = stack->tail;
>          guththila_stack_free_rec (environment, stack, ele);
>          GUTHTHILA_FREE (environment->allocator, stack);
>      }
> +    else
> +      GUTHTHILA_FREE (environment->allocator, stack);
>  }
>  

Mime
View raw message