axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Frederic Heem (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AXIS2C-1156) memory leak in savanc
Date Wed, 02 Jul 2008 14:49:45 GMT

    [ https://issues.apache.org/jira/browse/AXIS2C-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609943#action_12609943
] 

Frederic Heem commented on AXIS2C-1156:
---------------------------------------

This patch is an improvement but doesn't really fix the problem. Indeed, the function returns
before savan_sub_processor_free get the chance to be called. 
Moreover, the local variable  "from_client" is set to a value but is not used at all because
a return is called immediately after. 
Why not have a switch instead of the if then else ? Let's remove all the return statement
except the one after savan_sub_processor_free. Finally, let's remove all the tab for the sake
of code readability. What do you reckon ?
Regards, 

> memory leak in savanc
> ---------------------
>
>                 Key: AXIS2C-1156
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-1156
>             Project: Axis2-C
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>         Environment: linux fc5
>            Reporter: Frederic Heem
>            Assignee: Damitha Kumarage
>             Fix For: 1.4.1
>
>         Attachments: sub_processor.patch
>
>
> In savan_in_handler_invoke(), a processor is created by savan_sub_processor_create()
 but it is not freed, actually, there isn't a function to free it (savan_sub_processor_free()
?)
> Also there is a mix of tab and spaces in the file which makes it difficult to read and
maintain.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


Mime
View raw message