axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Glyn Normington" <glyn_norming...@uk.ibm.com>
Subject Re: [PATCH] onFault rename/bug fix/testcase
Date Thu, 10 Jan 2002 15:17:08 GMT

I noticed a bad character in the previous note that wasn't in my original
patch file. Here's the corrected version of the patch. The new file is
unchanged.

Glyn

Index: xml-axis/java/samples/transport/FileSender.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/samples/transport/FileSender.java,v
retrieving revision 1.11
diff -u -r1.11 FileSender.java
--- xml-axis/java/samples/transport/FileSender.java     2 Nov 2001 03:07:40
-0000     1.11
+++ xml-axis/java/samples/transport/FileSender.java     10 Jan 2002
12:28:31 -0000
@@ -125,7 +125,4 @@
         throw new AxisFault("timeout");

   }
-
-  public void undo(MessageContext msgContext) {
-  }
 }
Index: xml-axis/java/samples/transport/tcp/TCPSender.java
===================================================================
RCS file:
/home/cvspublic/xml-axis/java/samples/transport/tcp/TCPSender.java,v
retrieving revision 1.12
diff -u -r1.12 TCPSender.java
--- xml-axis/java/samples/transport/tcp/TCPSender.java  3 Dec 2001 22:49:22
-0000     1.12
+++ xml-axis/java/samples/transport/tcp/TCPSender.java  10 Jan 2002
12:28:32 -0000
@@ -140,9 +140,4 @@
         }
         category.info( "Exit: TCPSender::invoke" );
     }
-
-    public void undo(MessageContext msgContext) {
-        category.debug("Enter: TCPSender::undo" );
-        category.debug("Exit: TCPSender::undo" );
-    }
 };
Index: xml-axis/java/samples/userguide/example4/LogHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/samples/userguide/example4/LogHandler.java,v
retrieving revision 1.8
diff -u -r1.8 LogHandler.java
--- xml-axis/java/samples/userguide/example4/LogHandler.java      3 Dec 2001 22:49:22 -0000
    1.8
+++ xml-axis/java/samples/userguide/example4/LogHandler.java      10 Jan 2002 12:28:32 -0000
@@ -100,8 +100,4 @@
             throw AxisFault.makeFault(e);
         }
     }
-
-    public void undo(MessageContext msgContext)
-    {
-    }
-}
\ No newline at end of file
+}
Index: xml-axis/java/src/org/apache/axis/FaultableHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/FaultableHandler.java,v
retrieving revision 1.29
diff -u -r1.29 FaultableHandler.java
--- xml-axis/java/src/org/apache/axis/FaultableHandler.java  3 Dec 2001 22:49:22 -0000   
 1.29
+++ xml-axis/java/src/org/apache/axis/FaultableHandler.java  10 Jan 2002 12:28:32 -0000
@@ -98,7 +98,7 @@
      * Invokes the specified handler.  If there's a fault the appropriate
      * key will be calculated and used to find the fault chain to be
      * invoked.  This assumes that the workHandler has caught the exception
-     * and already processed it's undo logic - as needed.
+     * and already done its fault processing - as needed.
      */
     public void invoke(MessageContext msgContext) throws AxisFault {
         category.debug(JavaUtils.getMessage("enter00", "FaultableHandler::invoke"));
@@ -148,12 +148,12 @@
     }

     /**
-     * Some handler later on has faulted so we need to undo our work.
+     * Some handler later on has faulted so we need to process the fault.
      */
-    public void undo(MessageContext msgContext) {
-        category.debug(JavaUtils.getMessage("enter00", "FaultableHandler::undo"));
-        workHandler.undo( msgContext );
-        category.debug(JavaUtils.getMessage("exit00", "FaultableHandler::undo"));
+    public void onFault(MessageContext msgContext) {
+        category.debug(JavaUtils.getMessage("enter00", "FaultableHandler::onFault"));
+        workHandler.onFault( msgContext );
+        category.debug(JavaUtils.getMessage("exit00", "FaultableHandler::onFault"));
     };

     public boolean canHandleBlock(QName qname) {
Index: xml-axis/java/src/org/apache/axis/Handler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/Handler.java,v
retrieving revision 1.23
diff -u -r1.23 Handler.java
--- xml-axis/java/src/org/apache/axis/Handler.java      9 Nov 2001 23:17:47 -0000     1.23
+++ xml-axis/java/src/org/apache/axis/Handler.java      10 Jan 2002 12:28:33 -0000
@@ -84,16 +84,16 @@
      * If there is a fault during the processing of this method it is
      * invoke's job to catch the exception and undo any partial work
      * that has been completed.  Once we leave 'invoke' if a fault
-     * is thrown, this classes 'undo' method will be called to undo
-     * the work that 'invoke' did.
-     * Invoke should rethrow any exceptions it catches.
+     * is thrown, this classes 'onFault' method will be called.
+     * Invoke should rethrow any exceptions it catches, wrapped in
+     * an AxisFault.
      */
     public void invoke(MessageContext msgContext) throws AxisFault ;

     /**
-     * Called when a fault occurs to 'undo' whatever 'invoke' did.
+     * Called when a subsequent handler throws a fault.
      */
-    public void undo(MessageContext msgContext);
+    public void onFault(MessageContext msgContext);

     /**
      * Can this Handler process this QName?
Index: xml-axis/java/src/org/apache/axis/SimpleChain.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/SimpleChain.java,v
retrieving revision 1.37
diff -u -r1.37 SimpleChain.java
--- xml-axis/java/src/org/apache/axis/SimpleChain.java  23 Dec 2001 14:52:36 -0000    1.37
+++ xml-axis/java/src/org/apache/axis/SimpleChain.java  10 Jan 2002 12:28:33 -0000
@@ -96,7 +96,7 @@

     /**
      * Iterate over the chain invoking each handler.  If there's a fault
-     * then call 'undo' for each completed handler in reverse order, then
+     * then call 'onFault' for each completed handler in reverse order, then
      * rethrow the exception.
      */
     public void invoke(MessageContext msgContext) throws AxisFault {
@@ -125,17 +125,22 @@
         try {
             Vector localHandlers;
             // copies handlers to a local variable for thread-safe
+            // Unfortunately, localHandlers and handlers are references
+            // that point at the same Vector so this doesn't give
+            // thread safety.
             if ((localHandlers = handlers) != null) {
                 Enumeration enum = localHandlers.elements();
-                while (enum.hasMoreElements())
+                while (enum.hasMoreElements()) {
                     visitor.visit((Handler)enum.nextElement(), msgContext);
+                    i++;
+         }
             }
         }
         catch( Exception e ) {
-            // undo in reverse order - rethrow
+            // notify fault in reverse order and then rethrow
             category.error( e );
             while( --i >= 0 )
-                ((Handler) handlers.elementAt( i )).undo( msgContext );
+                ((Handler) handlers.elementAt( i )).onFault( msgContext );
             throw AxisFault.makeFault(e);
         }

@@ -146,20 +151,22 @@
     }

     /**
-     * Undo all of the work this chain completed because some handler
-     * later on has faulted - in reverse order.
+     * Notify the handlers in this chain because some handler
+     * later on has faulted - in reverse order. If any handlers
+     * have been added since we visited the chain, they will get
+     * notified too!
      */
-    public void undo(MessageContext msgContext) {
+    public void onFault(MessageContext msgContext) {
         if (category.isDebugEnabled()) {
             category.debug(JavaUtils.getMessage("enter00",
-                "SimpleChain::undo"));
+                "SimpleChain::onFault"));
         }

         for ( int i = handlers.size()-1 ; i >= 0 ; i-- )
-            ((Handler) handlers.elementAt( i )).undo( msgContext );
+            ((Handler) handlers.elementAt( i )).onFault( msgContext );

         if (category.isDebugEnabled()) {
-            category.debug(JavaUtils.getMessage("exit00", "SimpleChain::undo"));
+            category.debug(JavaUtils.getMessage("exit00", "SimpleChain::onFault"));
         }
     }

Index: xml-axis/java/src/org/apache/axis/SimpleTargetedChain.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/SimpleTargetedChain.java,v
retrieving revision 1.34
diff -u -r1.34 SimpleTargetedChain.java
--- xml-axis/java/src/org/apache/axis/SimpleTargetedChain.java    3 Jan 2002 18:08:28 -0000
    1.34
+++ xml-axis/java/src/org/apache/axis/SimpleTargetedChain.java    10 Jan 2002 12:28:33 -0000
@@ -86,8 +86,6 @@
    private class PivotIndicator extends BasicHandler {
        public PivotIndicator() {}

-       public void undo(MessageContext msgContext) {}
-
        public void invoke(MessageContext msgContext) throws AxisFault {
            msgContext.setPastPivot(true);
        }
Index: xml-axis/java/src/org/apache/axis/client/AxisClient.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/client/AxisClient.java,v
retrieving revision 1.34
diff -u -r1.34 AxisClient.java
--- xml-axis/java/src/org/apache/axis/client/AxisClient.java      5 Dec 2001 00:27:18 -0000
    1.34
+++ xml-axis/java/src/org/apache/axis/client/AxisClient.java      10 Jan 2002 12:28:33 -0000
@@ -209,12 +209,5 @@
                 "AxisClient::invoke") );
         }
     };
-
-    public void undo(MessageContext msgContext) {
-        if (category.isDebugEnabled()) {
-            category.debug(JavaUtils.getMessage("enter00", "AxisClient::undo"));
-            category.debug(JavaUtils.getMessage("exit00", "AxisClient::undo") );
-        }
-    }
 }

Index: xml-axis/java/src/org/apache/axis/handlers/BasicHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/BasicHandler.java,v
retrieving revision 1.22
diff -u -r1.22 BasicHandler.java
--- xml-axis/java/src/org/apache/axis/handlers/BasicHandler.java  9 Nov 2001 23:17:47 -0000
    1.22
+++ xml-axis/java/src/org/apache/axis/handlers/BasicHandler.java  10 Jan 2002 12:28:34 -0000
@@ -98,9 +98,9 @@
         return false;
     }

-    /** Must implement this in subclasses.
-     */
-    public abstract void undo(MessageContext msgContext);
+    public void onFault(MessageContext msgContext)
+    {
+    }

     /** Must implement this in subclasses.
      */
Index: xml-axis/java/src/org/apache/axis/handlers/DebugHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/DebugHandler.java,v
retrieving revision 1.27
diff -u -r1.27 DebugHandler.java
--- xml-axis/java/src/org/apache/axis/handlers/DebugHandler.java  12 Dec 2001 18:17:52 -0000
   1.27
+++ xml-axis/java/src/org/apache/axis/handlers/DebugHandler.java  10 Jan 2002 12:28:34 -0000
@@ -101,9 +101,9 @@
         category.debug(JavaUtils.getMessage("exit00", "DebugHandler::invoke") );
     }

-    public void undo(MessageContext msgContext) {
-        category.debug(JavaUtils.getMessage("enter00", "DebugHandler::undo") );
-        category.debug(JavaUtils.getMessage("exit00", "DebugHandler::undo") );
+    public void onFault(MessageContext msgContext) {
+        category.debug(JavaUtils.getMessage("enter00", "DebugHandler::onFault") );
+        category.debug(JavaUtils.getMessage("exit00", "DebugHandler::onFault") );
     }

 };
Index: xml-axis/java/src/org/apache/axis/handlers/EchoHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/EchoHandler.java,v
retrieving revision 1.25
diff -u -r1.25 EchoHandler.java
--- xml-axis/java/src/org/apache/axis/handlers/EchoHandler.java   12 Dec 2001 18:17:52 -0000
   1.25
+++ xml-axis/java/src/org/apache/axis/handlers/EchoHandler.java   10 Jan 2002 12:28:34 -0000
@@ -84,9 +84,4 @@
         category.debug(JavaUtils.getMessage("exit00", "EchoHandler::invoke") );
     }

-    public void undo(MessageContext msgContext) {
-        category.debug(JavaUtils.getMessage("enter00", "EchoHandler::undo") );
-        category.debug(JavaUtils.getMessage("exit00", "EchoHandler::undo") );
-    }
-
 };
Index: xml-axis/java/src/org/apache/axis/handlers/ErrorHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/ErrorHandler.java,v
retrieving revision 1.15
diff -u -r1.15 ErrorHandler.java
--- xml-axis/java/src/org/apache/axis/handlers/ErrorHandler.java  7 Nov 2001 15:13:46 -0000
    1.15
+++ xml-axis/java/src/org/apache/axis/handlers/ErrorHandler.java  10 Jan 2002 12:28:34 -0000
@@ -74,9 +74,4 @@
         throw new AxisFault( "Server.Whatever", "ERROR", null, null );
     }

-    public void undo(MessageContext msgContext) {
-        category.debug(JavaUtils.getMessage("enter00", "ErrorHandler::undo") );
-        category.debug(JavaUtils.getMessage("exit00", "ErrorHandler::undo") );
-    }
-
 };
Index: xml-axis/java/src/org/apache/axis/handlers/JWSHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/JWSHandler.java,v
retrieving revision 1.10
diff -u -r1.10 JWSHandler.java
--- xml-axis/java/src/org/apache/axis/handlers/JWSHandler.java    15 Nov 2001 14:07:39 -0000
   1.10
+++ xml-axis/java/src/org/apache/axis/handlers/JWSHandler.java    10 Jan 2002 12:28:34 -0000
@@ -95,12 +95,4 @@
     public void generateWSDL(MessageContext msgContext) throws AxisFault {
         invoke(msgContext);
     }
-
-    public void undo(MessageContext msgContext)
-    {
-        if (category.isDebugEnabled()) {
-            category.debug(JavaUtils.getMessage("enter00", "JWSHandler::undo"));
-            category.debug(JavaUtils.getMessage("exit00", "JWSHandler::undo"));
-        }
-    }
 }
Index: xml-axis/java/src/org/apache/axis/handlers/JWSProcessor.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/JWSProcessor.java,v
retrieving revision 1.31
diff -u -r1.31 JWSProcessor.java
--- xml-axis/java/src/org/apache/axis/handlers/JWSProcessor.java  10 Dec 2001 22:25:53 -0000
   1.31
+++ xml-axis/java/src/org/apache/axis/handlers/JWSProcessor.java  10 Jan 2002 12:28:35 -0000
@@ -259,14 +259,6 @@
         invokeImpl(msgContext, true);
     }

-    public void undo(MessageContext msgContext)
-    {
-        if (category.isDebugEnabled()) {
-            category.debug(JavaUtils.getMessage("enter00", "JWSProcessor::undo"));
-            category.debug(JavaUtils.getMessage("exit00", "JWSProcessor::undo"));
-        }
-    }
-
     private String getDefaultClasspath(MessageContext msgContext)
     {
         StringBuffer classpath = new StringBuffer();
Index: xml-axis/java/src/org/apache/axis/handlers/LogMessage.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/LogMessage.java,v
retrieving revision 1.8
diff -u -r1.8 LogMessage.java
--- xml-axis/java/src/org/apache/axis/handlers/LogMessage.java    7 Nov 2001 15:13:46 -0000
    1.8
+++ xml-axis/java/src/org/apache/axis/handlers/LogMessage.java    10 Jan 2002 12:28:35 -0000
@@ -80,9 +80,4 @@
         if (msg != null)
             category.log(Priority.INFO, msg);
     }
-
-    public void undo(MessageContext msgContext) {
-        category.debug(JavaUtils.getMessage("enter00", "LogMessage::undo") );
-        category.debug(JavaUtils.getMessage("exit00", "LogMessage::undo") );
-    }
 }
Index: xml-axis/java/src/org/apache/axis/handlers/MD5AttachHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/MD5AttachHandler.java,v
retrieving revision 1.3
diff -u -r1.3 MD5AttachHandler.java
--- xml-axis/java/src/org/apache/axis/handlers/MD5AttachHandler.java   3 Dec 2001 22:49:23
-0000     1.3
+++ xml-axis/java/src/org/apache/axis/handlers/MD5AttachHandler.java   10 Jan 2002 12:28:36
-0000
@@ -157,10 +157,4 @@
         }
         category.debug(JavaUtils.getMessage("exit00", "EchoHandler::invoke") );
     }
-
-    public void undo(MessageContext msgContext) {
-        category.debug(JavaUtils.getMessage("enter00", "EchoHandler::undo") );
-        category.debug(JavaUtils.getMessage("exit00", "EchoHandler::undo") );
-    }
-
 }
Index: xml-axis/java/src/org/apache/axis/handlers/SimpleAuthenticationHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/SimpleAuthenticationHandler.java,v
retrieving revision 1.23
diff -u -r1.23 SimpleAuthenticationHandler.java
--- xml-axis/java/src/org/apache/axis/handlers/SimpleAuthenticationHandler.java  15 Nov 2001
12:08:11 -0000     1.23
+++ xml-axis/java/src/org/apache/axis/handlers/SimpleAuthenticationHandler.java  10 Jan 2002
12:28:37 -0000
@@ -130,17 +130,4 @@
                 "SimpleAuthenticationHandler::invoke") );
         }
     }
-
-    /**
-     * Nothing to undo
-     */
-    public void undo(MessageContext msgContext) {
-        if (category.isDebugEnabled()) {
-            category.debug(JavaUtils.getMessage("enter00",
-                "SimpleAuthenticationHandler::undo") );
-
-            category.debug(JavaUtils.getMessage("exit00",
-                "SimpleAuthenticationHandler::undo") );
-        }
-    }
 };
Index: xml-axis/java/src/org/apache/axis/handlers/SimpleSessionHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/SimpleSessionHandler.java,v
retrieving revision 1.10
diff -u -r1.10 SimpleSessionHandler.java
--- xml-axis/java/src/org/apache/axis/handlers/SimpleSessionHandler.java    12 Dec 2001 18:17:52
-0000    1.10
+++ xml-axis/java/src/org/apache/axis/handlers/SimpleSessionHandler.java    10 Jan 2002 12:28:38
-0000
@@ -297,11 +297,6 @@
         return id;
     }

-    public void undo(MessageContext msgContext) {
-        category.debug(JavaUtils.getMessage("enter00", "SimpleSessionHandler::undo") );
-        category.debug(JavaUtils.getMessage("exit00", "SimpleSessionHandler::undo") );
-    }
-
     /**
      * Set the reaper periodicity - convenience method for testing.
      *
Index: xml-axis/java/src/org/apache/axis/handlers/http/HTTPActionHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/http/HTTPActionHandler.java,v
retrieving revision 1.12
diff -u -r1.12 HTTPActionHandler.java
--- xml-axis/java/src/org/apache/axis/handlers/http/HTTPActionHandler.java  7 Nov 2001 15:13:47
-0000     1.12
+++ xml-axis/java/src/org/apache/axis/handlers/http/HTTPActionHandler.java  10 Jan 2002 12:28:38
-0000
@@ -118,10 +118,4 @@

         category.debug(JavaUtils.getMessage("exit00", "HTTPActionHandler::invoke") );
     }
-
-    public void undo(MessageContext msgContext)
-    {
-        category.debug(JavaUtils.getMessage("enter00", "HTTPActionHandler::undo") );
-        category.debug(JavaUtils.getMessage("exit00", "HTTPActionHandler::undo") );
-    }
 }
Index: xml-axis/java/src/org/apache/axis/handlers/http/HTTPAuthHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/http/HTTPAuthHandler.java,v
retrieving revision 1.9
diff -u -r1.9 HTTPAuthHandler.java
--- xml-axis/java/src/org/apache/axis/handlers/http/HTTPAuthHandler.java    7 Nov 2001 15:13:47
-0000     1.9
+++ xml-axis/java/src/org/apache/axis/handlers/http/HTTPAuthHandler.java    10 Jan 2002 12:28:38
-0000
@@ -103,10 +103,4 @@

         category.debug(JavaUtils.getMessage("exit00", "HTTPAuthHandler::invoke") );
     }
-
-    public void undo(MessageContext msgContext)
-    {
-        category.debug(JavaUtils.getMessage("enter00", "HTTPActionHandler::undo") );
-        category.debug(JavaUtils.getMessage("exit00", "HTTPActionHandler::undo") );
-    }
 }
Index: xml-axis/java/src/org/apache/axis/handlers/http/URLMapper.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/http/URLMapper.java,v
retrieving revision 1.12
diff -u -r1.12 URLMapper.java
--- xml-axis/java/src/org/apache/axis/handlers/http/URLMapper.java     7 Nov 2001 15:13:47
-0000     1.12
+++ xml-axis/java/src/org/apache/axis/handlers/http/URLMapper.java     10 Jan 2002 12:28:39
-0000
@@ -93,10 +93,4 @@
     public void generateWSDL(MessageContext msgContext) throws AxisFault {
         invoke(msgContext);
     }
-
-    public void undo(MessageContext msgContext)
-    {
-        category.debug(JavaUtils.getMessage("enter00", "URLMapper::undo") );
-        category.debug(JavaUtils.getMessage("exit00", "URLMapper::undo") );
-    }
 }
Index: xml-axis/java/src/org/apache/axis/handlers/soap/SOAPService.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/handlers/soap/SOAPService.java,v
retrieving revision 1.41
diff -u -r1.41 SOAPService.java
--- xml-axis/java/src/org/apache/axis/handlers/soap/SOAPService.java   3 Jan 2002 18:08:28
-0000     1.41
+++ xml-axis/java/src/org/apache/axis/handlers/soap/SOAPService.java   10 Jan 2002 12:28:39
-0000
@@ -111,8 +111,6 @@
     private class SOAPRequestHandler extends BasicHandler {
         public SOAPRequestHandler() {}

-        public void undo(MessageContext msgContext) {}
-
         public void invoke(MessageContext msgContext) throws AxisFault {
             // Do SOAP semantics here
             if (category.isDebugEnabled()) {
Index: xml-axis/java/src/org/apache/axis/providers/BSFProvider.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/providers/BSFProvider.java,v
retrieving revision 1.2
diff -u -r1.2 BSFProvider.java
--- xml-axis/java/src/org/apache/axis/providers/BSFProvider.java  30 Oct 2001 14:19:30 -0000
   1.2
+++ xml-axis/java/src/org/apache/axis/providers/BSFProvider.java  10 Jan 2002 12:28:39 -0000
@@ -67,6 +67,4 @@
         System.out.println(getOption("Script"));
     }

-    public void undo(MessageContext msgContext) {
-    }
 }
Index: xml-axis/java/src/org/apache/axis/providers/ComProvider.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/providers/ComProvider.java,v
retrieving revision 1.2
diff -u -r1.2 ComProvider.java
--- xml-axis/java/src/org/apache/axis/providers/ComProvider.java  30 Oct 2001 14:19:30 -0000
   1.2
+++ xml-axis/java/src/org/apache/axis/providers/ComProvider.java  10 Jan 2002 12:28:39 -0000
@@ -66,7 +66,4 @@
     public void invoke(MessageContext msgContext) {
     }

-    public void undo(MessageContext msgContext) {
-    }
-
 }
Index: xml-axis/java/src/org/apache/axis/providers/JWSProvider.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/providers/JWSProvider.java,v
retrieving revision 1.2
diff -u -r1.2 JWSProvider.java
--- xml-axis/java/src/org/apache/axis/providers/JWSProvider.java  30 Oct 2001 14:19:30 -0000
   1.2
+++ xml-axis/java/src/org/apache/axis/providers/JWSProvider.java  10 Jan 2002 12:28:39 -0000
@@ -61,7 +61,4 @@

     public void invoke(MessageContext msgContext) {
     }
-
-    public void undo(MessageContext msgContext) {
-    }
 }
Index: xml-axis/java/src/org/apache/axis/providers/java/JavaProvider.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/providers/java/JavaProvider.java,v
retrieving revision 1.30
diff -u -r1.30 JavaProvider.java
--- xml-axis/java/src/org/apache/axis/providers/java/JavaProvider.java      12 Dec 2001 18:17:52
-0000    1.30
+++ xml-axis/java/src/org/apache/axis/providers/java/JavaProvider.java      10 Jan 2002 12:28:40
-0000
@@ -320,11 +320,6 @@



-    public void undo(MessageContext msgContext) {
-        category.debug(JavaUtils.getMessage("enter00", "RPCDispatchHandler::undo") );
-        category.debug(JavaUtils.getMessage("exit00", "RPCDispatchHandler::undo") );
-    }
-
     ///////////////////////////////////////////////////////////////
     ///////////////////////////////////////////////////////////////
     /////// Default methods for java classes. Override, eg, for
Index: xml-axis/java/src/org/apache/axis/providers/java/MsgProvider.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/providers/java/MsgProvider.java,v
retrieving revision 1.20
diff -u -r1.20 MsgProvider.java
--- xml-axis/java/src/org/apache/axis/providers/java/MsgProvider.java  17 Dec 2001 00:57:41
-0000    1.20
+++ xml-axis/java/src/org/apache/axis/providers/java/MsgProvider.java  10 Jan 2002 12:28:40
-0000
@@ -244,10 +244,4 @@
             resEnv.addBodyElement(el);
         }
     }
-
-
-    public void undo(MessageContext msgContext) {
-        category.debug(JavaUtils.getMessage("enter00", "MsgDispatcherHandler::undo") );
-        category.debug(JavaUtils.getMessage("exit00", "MsgDispatcherHandler::undo") );
-    }
 };
Index: xml-axis/java/src/org/apache/axis/server/AxisServer.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/server/AxisServer.java,v
retrieving revision 1.53
diff -u -r1.53 AxisServer.java
--- xml-axis/java/src/org/apache/axis/server/AxisServer.java      12 Dec 2001 18:17:52 -0000
   1.53
+++ xml-axis/java/src/org/apache/axis/server/AxisServer.java      10 Jan 2002 12:28:42 -0000
@@ -462,11 +462,4 @@
                 "AxisServer::generateWSDL") );
         }
     }
-
-    public void undo(MessageContext msgContext) {
-        if (category.isDebugEnabled()) {
-            category.debug(JavaUtils.getMessage("enter00", "AxisServer::undo"));
-            category.debug(JavaUtils.getMessage("exit00", "AxisServer::undo"));
-        }
-    };
 };
Index: xml-axis/java/src/org/apache/axis/transport/http/HTTPSender.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/transport/http/HTTPSender.java,v
retrieving revision 1.44
diff -u -r1.44 HTTPSender.java
--- xml-axis/java/src/org/apache/axis/transport/http/HTTPSender.java   12 Dec 2001 18:17:52
-0000    1.44
+++ xml-axis/java/src/org/apache/axis/transport/http/HTTPSender.java   10 Jan 2002 12:28:44
-0000
@@ -723,15 +723,5 @@
         }
         return true;
     }
-
-
-    public void undo(MessageContext msgContext) {
-        if (category.isDebugEnabled()) {
-            category.debug( JavaUtils.getMessage("enter00",
-                "HTTPDispatchHandler::undo") );
-            category.debug( JavaUtils.getMessage("exit00",
-                "HTTPDispatchHandler::undo") );
-        }
-    }
 };

Index: xml-axis/java/src/org/apache/axis/transport/local/LocalResponder.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/transport/local/LocalResponder.java,v
retrieving revision 1.10
diff -u -r1.10 LocalResponder.java
--- xml-axis/java/src/org/apache/axis/transport/local/LocalResponder.java   15 Nov 2001 14:45:57
-0000    1.10
+++ xml-axis/java/src/org/apache/axis/transport/local/LocalResponder.java   10 Jan 2002 12:28:44
-0000
@@ -84,13 +84,4 @@
                 "LocalResponder::invoke") );
         }
     }
-
-    public void undo(MessageContext msgContext) {
-        if (category.isDebugEnabled()) {
-            category.debug(JavaUtils.getMessage("enter00",
-                "LocalResponder::undo") );
-            category.debug(JavaUtils.getMessage("exit00",
-                "LocalResponder::undo") );
-        }
-    }
 };
Index: xml-axis/java/src/org/apache/axis/transport/local/LocalSender.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/transport/local/LocalSender.java,v
retrieving revision 1.22
diff -u -r1.22 LocalSender.java
--- xml-axis/java/src/org/apache/axis/transport/local/LocalSender.java      12 Dec 2001 18:17:52
-0000    1.22
+++ xml-axis/java/src/org/apache/axis/transport/local/LocalSender.java      10 Jan 2002 12:28:45
-0000
@@ -174,14 +174,4 @@
                 "LocalSender::invoke"));
         }
     }
-
-    public void undo(MessageContext msgContext) {
-        if (category.isDebugEnabled()) {
-            category.debug(JavaUtils.getMessage("enter00",
-                "LocalSender::undo"));
-
-            category.debug(JavaUtils.getMessage("exit00",
-                "LocalSender::undo"));
-        }
-    }
 };
Index: xml-axis/java/test/chains/PackageTests.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/test/chains/PackageTests.java,v
retrieving revision 1.1
diff -u -r1.1 PackageTests.java
--- xml-axis/java/test/chains/PackageTests.java    7 Jan 2002 15:15:53 -0000     1.1
+++ xml-axis/java/test/chains/PackageTests.java    10 Jan 2002 12:28:45 -0000
@@ -16,6 +16,7 @@
         TestSuite suite = new TestSuite("All axis Chain tests");

         suite.addTest(TestSimpleChain.suite());
+        suite.addTest(TestChainFault.suite());
         return suite;
     }
 }
Index: xml-axis/java/test/chains/TestSimpleChain.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/test/chains/TestSimpleChain.java,v
retrieving revision 1.3
diff -u -r1.3 TestSimpleChain.java
--- xml-axis/java/test/chains/TestSimpleChain.java      8 Jan 2002 14:51:39 -0000     1.3
+++ xml-axis/java/test/chains/TestSimpleChain.java      10 Jan 2002 12:28:45 -0000
@@ -81,7 +81,6 @@
     private class TestHandler extends BasicHandler {
         public TestHandler() {}
         public void invoke(MessageContext msgContext) throws AxisFault {}
-        public void undo(MessageContext msgContext) {}
     }

     public void testSimpleChainAddHandler()
Index: xml-axis/java/test/outparams/ServiceHandler.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/test/outparams/ServiceHandler.java,v
retrieving revision 1.6
diff -u -r1.6 ServiceHandler.java
--- xml-axis/java/test/outparams/ServiceHandler.java    30 Oct 2001 16:46:42 -0000    1.6
+++ xml-axis/java/test/outparams/ServiceHandler.java    10 Jan 2002 12:28:45 -0000
@@ -68,11 +68,6 @@
     public static final Float OUTPARAM2 = new Float(4.56);
     public static final Integer RESPONSE = new Integer(5);

-    /** Must implement this in subclasses.
-     */
-    public void undo(MessageContext msgContext) {
-    }
-
     public void invoke(MessageContext msgContext) throws AxisFault {
         SOAPEnvelope env = new SOAPEnvelope();



Mime
View raw message