axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Davanum Srinivas <dava...@gmail.com>
Subject Re: cvs commit: ws-axis/java/src/org/apache/axis SOAPPart.java
Date Mon, 23 May 2005 14:24:00 GMT
+1 :)

On 5/23/05, Venkat Reddy <vreddyp@gmail.com> wrote:
> Okay, i'm going to turn to the other alternative - setting dirty flag
> to true on the relavant nodes at the time of modification to the
> message.
> 
> - Venkat
> 
> 
> On 5/23/05, Davanum Srinivas <davanum@gmail.com> wrote:
> > -1...this is gonna cause big performance problems.
> >
> > -- dims
> >
> > On 23 May 2005 13:26:48 -0000, venkat@apache.org <venkat@apache.org> wrote:
> > > venkat      2005/05/23 06:26:48
> > >
> > >   Modified:    java/src/org/apache/axis SOAPPart.java
> > >   Log:
> > >   Fix for the bug : AXIS-1960 - SOAPPart.saveChanges() doesn't work.
> > >
> > >   SOAPPart.writeTo(array) was not working because MessageElement.output() simply
replays the recorder and misses the latest changes.
> > >   The other way to fix this is to call setDirty(true) on all message elements
recursively, while inside SOAPPart.saveChanges(). But i dont think it is optimal either.
> > >
> > >   Revision  Changes    Path
> > >   1.78      +1 -1      ws-axis/java/src/org/apache/axis/SOAPPart.java
> > >
> > >   Index: SOAPPart.java
> > >   ===================================================================
> > >   RCS file: /home/cvs/ws-axis/java/src/org/apache/axis/SOAPPart.java,v
> > >   retrieving revision 1.77
> > >   retrieving revision 1.78
> > >   diff -u -r1.77 -r1.78
> > >   --- SOAPPart.java     28 Feb 2005 15:57:07 -0000      1.77
> > >   +++ SOAPPart.java     23 May 2005 13:26:48 -0000      1.78
> > >   @@ -527,7 +527,7 @@
> > >                currentEncoding = XMLUtils.getEncoding(msgObject, null);
> > >                ByteArray array = new ByteArray();
> > >                try {
> > >   -                this.writeTo(array);
> > >   +             array.write(XMLUtils.ElementToString(this.getMessage().getSOAPEnvelope()).getBytes());
> > >                    array.flush();
> > >                } catch (Exception e) {
> > >                    throw AxisFault.makeFault(e);
> > >
> > >
> > >
> > >
> >
> >
> > --
> > Davanum Srinivas - http://webservices.apache.org/~dims/
> >
> 


-- 
Davanum Srinivas - http://webservices.apache.org/~dims/

Mime
View raw message