axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From veit...@apache.org
Subject svn commit: r778216 - in /webservices/axis2/trunk/java/modules/kernel/test/org/apache/axis2/classloader: ./ JarFileClassLoaderTest.java
Date Sun, 24 May 2009 19:25:12 GMT
Author: veithen
Date: Sun May 24 19:25:12 2009
New Revision: 778216

URL: http://svn.apache.org/viewvc?rev=778216&view=rev
Log:
Added a regression test for AXIS2-4282.

Added:
    webservices/axis2/trunk/java/modules/kernel/test/org/apache/axis2/classloader/
    webservices/axis2/trunk/java/modules/kernel/test/org/apache/axis2/classloader/JarFileClassLoaderTest.java
  (with props)

Added: webservices/axis2/trunk/java/modules/kernel/test/org/apache/axis2/classloader/JarFileClassLoaderTest.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/test/org/apache/axis2/classloader/JarFileClassLoaderTest.java?rev=778216&view=auto
==============================================================================
--- webservices/axis2/trunk/java/modules/kernel/test/org/apache/axis2/classloader/JarFileClassLoaderTest.java
(added)
+++ webservices/axis2/trunk/java/modules/kernel/test/org/apache/axis2/classloader/JarFileClassLoaderTest.java
Sun May 24 19:25:12 2009
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.axis2.classloader;
+
+import java.io.File;
+import java.net.URL;
+
+import junit.framework.TestCase;
+
+import org.apache.commons.io.FileUtils;
+
+public class JarFileClassLoaderTest extends TestCase {
+    private File tmpDir;
+    
+    @Override
+    protected void setUp() throws Exception {
+        tmpDir = new File(System.getProperty("java.io.tmpdir"), getClass().getName());
+        if (tmpDir.exists()) {
+            FileUtils.deleteDirectory(tmpDir);
+        }
+        // Create the following files in the tmp directory:
+        // outside
+        // root/a
+        // root/dir/b
+        FileUtils.touch(new File(tmpDir, "outside"));
+        File root = new File(tmpDir, "root");
+        root.mkdir();
+        FileUtils.touch(new File(root, "a"));
+        File dir = new File(root, "dir");
+        dir.mkdir();
+        FileUtils.touch(new File(dir, "b"));
+    }
+
+    @Override
+    protected void tearDown() throws Exception {
+        FileUtils.deleteDirectory(tmpDir);
+    }
+
+    /**
+     * Test that if one of the URLs is a directory, the class loader doesn't allow access
to files
+     * outside of that directory (by using ".." in the resource name). See AXIS2-4282.
+     * <p>
+     * Note that while
+     * {@linkplain http://java.sun.com/j2se/1.4.2/docs/guide/resources/resources.html} suggests
+     * that ".." should be prohibited altogether, Sun's URLClassLoader implementation allows
this,
+     * as long as the resource name doesn't specify a file outside of the directory. E.g.
+     * "dir/../a" is an allowed resource name (equivalent to "a").
+     * 
+     * @throws Exception
+     */
+    public void testConfinement() throws Exception {
+        ClassLoader cl = new JarFileClassLoader(new URL[] { new File(tmpDir, "root").toURL()
});
+        assertNull(cl.getResource("../outside"));
+        assertNotNull(cl.getResource("a"));
+        assertNotNull(cl.getResource("dir/b"));
+    }
+}

Propchange: webservices/axis2/trunk/java/modules/kernel/test/org/apache/axis2/classloader/JarFileClassLoaderTest.java
------------------------------------------------------------------------------
    svn:eol-style = native



Mime
View raw message