axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Veithen <andreas.veit...@gmail.com>
Subject Re: svn commit: r759488 - in /webservices/axis2/trunk/java/modules: jaxws-integration/test/org/apache/axis2/jaxws/proxy/GorillaDLWProxyTests.java parent/pom.xml saaj/pom.xml
Date Fri, 18 Sep 2009 18:49:00 GMT
I fixed the dependencies of axis2-jaxws, and as a side effect,
xercesImpl is no longer packaged in the distribution. If somebody
comes up with evidence that there is an issue with this, then we
should add it back as an explicit dependency of the module that really
depends on it.

Andreas

On Fri, Sep 18, 2009 at 15:00, Deepal jayasinghe <deepalk@gmail.com> wrote:
> Amila and Andreas,
>
> I think Andreas's argument is valid so let's go with this changes. I
> also like to remove all the unwanted dependencies, because it is so hard
> to set up the project (w.o using maven), and we have so many dependencies.
>
> Thanks,
> Deepal
>> Since Axis2 1.5 depends on Java 1.5, there is no need to include
>> xercesImpl anymore and it works fine without it. Xerces still got
>> packaged into Axis2 1.5 because of an incorrect dependency in
>> axis2-jaxws: this module has a direct dependency on jaxen (which in
>> turn depends on xercesImpl), while it doesn't use Jaxen. This also
>> causes axis2-jaxws to have a transitive dependency on jdom, dom4j, XOM
>> and some other unnecessary stuff. If we fix the dependencies of
>> axis2-jaxws, xercesImpl will no longer be included in the dist and the
>> users can add the version they want if they have a specific need for
>> this.
>>
>> Note that up to now, there is no evidence that the xercesImpl version
>> causes any issues. The post by Wim Goossens probably means that in his
>> own code, he is using some feature that only exists in recent Xerces
>> versions. Unfortunately he didn't reply to my request to provide
>> additional information.
>>
>> Andreas
>>
>> On Fri, Sep 18, 2009 at 12:14, Amila Suriarachchi
>> <amilasuriarachchi@gmail.com> wrote:
>>
>>> hi Andreas,
>>>
>>> was there any discussion on dev list regarding this change?
>>> was there any problem with the XercesImpl-2.8.1.jar?
>>> would there be any advantage if this fixed worked correctly?
>>>
>>> I think if we don't have clear answer for latter two cases better to revert
>>> this change since this seems to be causing problems for some people.
>>>
>>> thanks,
>>> Amila.
>>>
>>> On Sat, Mar 28, 2009 at 9:21 PM, <veithen@apache.org> wrote:
>>>
>>>> Author: veithens
>>>> Date: Sat Mar 28 15:51:08 2009
>>>> New Revision: 759488
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=759488&view=rev
>>>> Log:
>>>> Removed dependencies on xml-apis and xercesImpl since the target platform
>>>> is now Java 5.
>>>>
>>>> Modified:
>>>>
>>>>  webservices/axis2/trunk/java/modules/jaxws-integration/test/org/apache/axis2/jaxws/proxy/GorillaDLWProxyTests.java
>>>>    webservices/axis2/trunk/java/modules/parent/pom.xml
>>>>    webservices/axis2/trunk/java/modules/saaj/pom.xml
>>>>
>>>> Modified:
>>>> webservices/axis2/trunk/java/modules/jaxws-integration/test/org/apache/axis2/jaxws/proxy/GorillaDLWProxyTests.java
>>>> URL:
>>>> http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/jaxws-integration/test/org/apache/axis2/jaxws/proxy/GorillaDLWProxyTests.java?rev=759488&r1=759487&r2=759488&view=diff
>>>>
>>>> ==============================================================================
>>>> ---
>>>> webservices/axis2/trunk/java/modules/jaxws-integration/test/org/apache/axis2/jaxws/proxy/GorillaDLWProxyTests.java
>>>> (original)
>>>> +++
>>>> webservices/axis2/trunk/java/modules/jaxws-integration/test/org/apache/axis2/jaxws/proxy/GorillaDLWProxyTests.java
>>>> Sat Mar 28 15:51:08 2009
>>>> @@ -25,7 +25,6 @@
>>>>  import org.apache.axis2.jaxws.framework.AbstractTestCase;
>>>>  import org.apache.axis2.jaxws.message.databinding.JAXBUtilsMonitor;
>>>>  import org.apache.axis2.jaxws.proxy.gorilla_dlw.sei.GorillaInterface;
>>>> -import org.apache.xerces.jaxp.datatype.DatatypeFactoryImpl;
>>>>
>>>>  import javax.xml.datatype.DatatypeFactory;
>>>>  import javax.xml.datatype.Duration;
>>>> @@ -482,7 +481,6 @@
>>>>                GorillaInterface proxy = getProxy();
>>>>                GregorianCalendar cal = new
>>>> GregorianCalendar(Calendar.YEAR, Calendar.MONTH, Calendar.DAY_OF_MONTH);
>>>>                DatatypeFactory javaxtypeFactory =
>>>> DatatypeFactory.newInstance();
>>>> -               DatatypeFactory xercesfactoryImpl =
>>>> DatatypeFactoryImpl.newInstance();
>>>>                XMLGregorianCalendar request=
>>>>  javaxtypeFactory.newXMLGregorianCalendar(cal);
>>>>                System.out.println("Javax Factory Clazz Name =
>>>> "+request.getClass().getName());
>>>>                Duration d =
>>>> javaxtypeFactory.newDuration(System.currentTimeMillis());
>>>>
>>>> Modified: webservices/axis2/trunk/java/modules/parent/pom.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/parent/pom.xml?rev=759488&r1=759487&r2=759488&view=diff
>>>>
>>>> ==============================================================================
>>>> --- webservices/axis2/trunk/java/modules/parent/pom.xml (original)
>>>> +++ webservices/axis2/trunk/java/modules/parent/pom.xml Sat Mar 28
>>>> 15:51:08 2009
>>>> @@ -142,8 +142,6 @@
>>>>         <woden.version>1.0-SNAPSHOT</woden.version>
>>>>         <wsdl4j.version>1.6.2</wsdl4j.version>
>>>>         <xalan.version>2.7.0</xalan.version>
>>>> -        <xerces.version>2.8.1</xerces.version>
>>>> -        <xml_apis.version>1.3.04</xml_apis.version>
>>>>         <xmlbeans.version>2.3.0</xmlbeans.version>
>>>>         <xml_resolver.version>1.2</xml_resolver.version>
>>>>         <xmlschema.version>1.4.3</xmlschema.version>
>>>> @@ -569,11 +567,6 @@
>>>>                 <version>${tomcat.version}</version>
>>>>             </dependency>
>>>>             <dependency>
>>>> -                <groupId>xml-apis</groupId>
>>>> -                <artifactId>xml-apis</artifactId>
>>>> -                <version>${xml_apis.version}</version>
>>>> -            </dependency>
>>>> -            <dependency>
>>>>                 <groupId>xml-resolver</groupId>
>>>>                 <artifactId>xml-resolver</artifactId>
>>>>                 <version>${xml_resolver.version}</version>
>>>> @@ -582,6 +575,12 @@
>>>>                 <groupId>xalan</groupId>
>>>>                 <artifactId>xalan</artifactId>
>>>>                 <version>${xalan.version}</version>
>>>> +                <exclusions>
>>>> +                    <exclusion>
>>>> +                        <groupId>xml-apis</groupId>
>>>> +                        <artifactId>xml-apis</artifactId>
>>>> +                    </exclusion>
>>>> +                </exclusions>
>>>>             </dependency>
>>>>             <dependency>
>>>>                 <groupId>com.sun.xml.bind</groupId>
>>>> @@ -702,6 +701,16 @@
>>>>                 <groupId>org.apache.ws.commons.axiom</groupId>
>>>>                 <artifactId>axiom-api</artifactId>
>>>>                 <version>${axiom.version}</version>
>>>> +                <exclusions>
>>>> +                    <exclusion>
>>>> +                        <groupId>xml-apis</groupId>
>>>> +                        <artifactId>xml-apis</artifactId>
>>>> +                    </exclusion>
>>>> +                    <exclusion>
>>>> +                        <groupId>xerces</groupId>
>>>> +                        <artifactId>xercesImpl</artifactId>
>>>> +                    </exclusion>
>>>> +                </exclusions>
>>>>             </dependency>
>>>>             <dependency>
>>>>                 <groupId>org.apache.ws.commons.axiom</groupId>
>>>> @@ -830,6 +839,10 @@
>>>>                         <groupId>org.codehaus.woodstox</groupId>
>>>>                         <artifactId>wstx-asl</artifactId>
>>>>                     </exclusion>
>>>> +                    <exclusion>
>>>> +                        <groupId>xerces</groupId>
>>>> +                        <artifactId>xmlParserAPIs</artifactId>
>>>> +                    </exclusion>
>>>>                 </exclusions>
>>>>             </dependency>
>>>>             <dependency>
>>>> @@ -841,6 +854,10 @@
>>>>                         <groupId>org.codehaus.woodstox</groupId>
>>>>                         <artifactId>wstx-asl</artifactId>
>>>>                     </exclusion>
>>>> +                    <exclusion>
>>>> +                        <groupId>xerces</groupId>
>>>> +                        <artifactId>xmlParserAPIs</artifactId>
>>>> +                    </exclusion>
>>>>                 </exclusions>
>>>>             </dependency>
>>>>             <dependency>
>>>> @@ -999,11 +1016,6 @@
>>>>                 <version>${jalopy.version}</version>
>>>>             </dependency>
>>>>             <dependency>
>>>> -                <groupId>xerces</groupId>
>>>> -                <artifactId>xercesImpl</artifactId>
>>>> -                <version>${xerces.version}</version>
>>>> -            </dependency>
>>>> -            <dependency>
>>>>                 <groupId>org.igniterealtime</groupId>
>>>>                 <artifactId>smack</artifactId>
>>>>                 <version>${smack.version}</version>
>>>> @@ -1072,10 +1084,6 @@
>>>>             <artifactId>geronimo-stax-api_1.0_spec</artifactId>
>>>>         </dependency>
>>>>         <dependency>
>>>> -            <groupId>xerces</groupId>
>>>> -            <artifactId>xercesImpl</artifactId>
>>>> -        </dependency>
>>>> -        <dependency>
>>>>             <groupId>org.apache.httpcomponents</groupId>
>>>>             <artifactId>httpcore</artifactId>
>>>>             <scope>test</scope>
>>>>
>>>> Modified: webservices/axis2/trunk/java/modules/saaj/pom.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/saaj/pom.xml?rev=759488&r1=759487&r2=759488&view=diff
>>>>
>>>> ==============================================================================
>>>> --- webservices/axis2/trunk/java/modules/saaj/pom.xml (original)
>>>> +++ webservices/axis2/trunk/java/modules/saaj/pom.xml Sat Mar 28 15:51:08
>>>> 2009
>>>> @@ -163,6 +163,8 @@
>>>>                     <skip>false</skip>
>>>>                     <forkMode>once</forkMode>
>>>>
>>>> <argLine>-Djava.endorsed.dirs=${m2Repository}/org/apache/geronimo/specs/geronimo-saaj_1.3_spec/${geronimo.spec.saaj.version}/</argLine>
>>>> +                    <!-- This fixes an issue on Sun JDKs caused
by the
>>>> presence of jaxp-ri on the classpath -->
>>>> +
>>>>  <argLine>-Dcom.sun.org.apache.xerces.internal.xni.parser.XMLParserConfiguration=com.sun.org.apache.xerces.internal.parsers.XIncludeParserConfiguration</argLine>
>>>>                 </configuration>
>>>>             </plugin>
>>>>         </plugins>
>>>>
>>>>
>>>>
>>>
>>> --
>>> Amila Suriarachchi
>>> WSO2 Inc.
>>> blog: http://amilachinthaka.blogspot.com/
>>>
>>>
>>
>>
>
>
> --
> Thank you!
>
>
> http://blogs.deepal.org
> http://deepal.org
>
>

Mime
View raw message