axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Thomas (JIRA)" <j...@apache.org>
Subject [jira] [Created] (AXIS2-5782) Maven axis2-repo-maven-plugin does not allow module names to be specified on multiple lines.
Date Thu, 09 Jun 2016 13:31:20 GMT
Jeff Thomas created AXIS2-5782:
----------------------------------

             Summary: Maven axis2-repo-maven-plugin does not allow module names to be specified
on multiple lines.
                 Key: AXIS2-5782
                 URL: https://issues.apache.org/jira/browse/AXIS2-5782
             Project: Axis2
          Issue Type: Improvement
          Components: Tools
    Affects Versions: 1.7.3
            Reporter: Jeff Thomas
            Priority: Minor
             Fix For: 1.7.4, 1.8.0


Currently the 'axis2-repo-maven-plugin' Maven Plugin does not permit you to place the named
modules on more than one line.  If you are configuring a lot of modules, then this leads to
a very long line.  Furthermore, if a line-break is added it breaks the plugin.

{code:xml}
<plugin>
  <groupId>org.apache.axis2</groupId>
  <artifactId>axis2-repo-maven-plugin</artifactId>
  <version>${axis2.version.pwc}</version>
  <executions>
    <execution>
      <id>axis2-modules-server</id>
      <phase>generate-resources</phase>
      <goals><goal>create-repository</goal></goals>
      <configuration>
        <outputDirectory>${project.build.directory}/webResources/WEB-INF</outputDirectory>
        <modules>addressing, rampart, soapmonitor, someModuleA, someModuleB, someModuleC,
someModuleD</modules>
      </configuration>
    </execution>
  </executions>
</plugin>
{code}

In my patched version, I have added three lines to "AbstractCreateRepositoryMojo.java" to
simply remove whitespace between the defined module names at the start of the execution.

{code:java}
public void execute() throws MojoExecutionException, MojoFailureException {
        Set<Artifact> artifacts = new HashSet<Artifact>();

        if (modules != null) {
            modules = modules.replaceAll("\\s", "");
        }
{code}

Thus I can specify:
{code:xml}
        <modules>
          addressing, 
          rampart, 
          soapmonitor, 
          someModuleA, 
          someModuleB, 
          someModuleC, 
          someModuleD
        </modules>
{code}

IMHO an even better configuration may be to replace the "modules" String in the MOJO with
a "List<String>" for:

{code:xml}
        <modules>
          <module>addressing</module>
          <module>rampart</module>
          <module>soapmonitor</module>
          <module>someModuleA</module>
          <module>someModuleB</module>
          <module>someModuleC</module> 
          <module>someModuleD</module>
        </modules>
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


Mime
View raw message