axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AXIS2-5856) Wrong null checker
Date Wed, 21 Jun 2017 20:10:00 GMT

    [ https://issues.apache.org/jira/browse/AXIS2-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058115#comment-16058115
] 

Hudson commented on AXIS2-5856:
-------------------------------

SUCCESS: Integrated in Jenkins build Axis2 #3798 (See [https://builds.apache.org/job/Axis2/3798/])
AXIS2-5856: Fix obvious bug in XMPPListener. (veithen: rev 1799496)
* (edit) axis2/modules/transport/xmpp/src/org/apache/axis2/transport/xmpp/XMPPListener.java


> Wrong null checker
> ------------------
>
>                 Key: AXIS2-5856
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5856
>             Project: Axis2
>          Issue Type: Bug
>          Components: XMPP transport
>            Reporter: JC
>            Priority: Trivial
>
> Hi 
> In a recent GitHub snapshot, I've found a following code smell.
> Path: modules/transport/xmpp/src/org/apache/axis2/transport/xmpp/XMPPListener.java
> {code}
> 165     public EndpointReference[] getEPRsForService(String serviceName, String ip) throws
AxisFault {
> 166         String domainName = serverCredentials.getDomainName() == null? serverCredentials.getDomainName()
> 167                         : serverCredentials.getServerUrl();
> 168         return new EndpointReference[]{new EndpointReference(XMPPConstants.XMPP_PREFIX
+
> 169                         serverCredentials.getAccountName() +"@"+ domainName +"/services/"
+ serviceName)};
> 170     }
> {code}
> In Line 166, serverCredentials.getDomainName() == null should be serverCredentials.getDomainName()
!= null ? This might be a trivial issue but wanted to report just in case.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


Mime
View raw message