beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Halperin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (BEAM-85) DataflowAssert (BeamAssert ;) needs sanity check that it's used correctly
Date Wed, 02 Mar 2016 20:54:18 GMT

     [ https://issues.apache.org/jira/browse/BEAM-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Daniel Halperin updated BEAM-85:
--------------------------------
    Description: 
It is important that assert is applied to pipeline before the pipeline is run, otherwise it
does not actually execute the test.

This code should throw an assertion error or fail in some other way.

{code}
Pipeline p = TestPipeline.create();
PCollection<Boolean> value = p.apply(Create.of(Boolean.FALSE));
p.run();

DataflowAssert.thatSingleton(value).isEqualTo(true);
{code}

but it would pass silently.

  was:
It is important that assert is applied to pipeline before the pipeline is run, otherwise it
does not actually execute the test.

This code should throw an assertion error or fail in some other way.

```java
{
Pipeline p = TestPipeline.create();
PCollection<Boolean> value = p.apply(Create.of(Boolean.FALSE));
p.run();

DataflowAssert.thatSingleton(value).isEqualTo(true);
}
```

but it would pass silently.


> DataflowAssert (BeamAssert ;) needs sanity check that it's used correctly
> -------------------------------------------------------------------------
>
>                 Key: BEAM-85
>                 URL: https://issues.apache.org/jira/browse/BEAM-85
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>
> It is important that assert is applied to pipeline before the pipeline is run, otherwise
it does not actually execute the test.
> This code should throw an assertion error or fail in some other way.
> {code}
> Pipeline p = TestPipeline.create();
> PCollection<Boolean> value = p.apply(Create.of(Boolean.FALSE));
> p.run();
> DataflowAssert.thatSingleton(value).isEqualTo(true);
> {code}
> but it would pass silently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message