beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-22) DirectPipelineRunner: support for unbounded collections
Date Fri, 15 Apr 2016 17:33:25 GMT


ASF GitHub Bot commented on BEAM-22:

GitHub user tgroh opened a pull request:

    [BEAM-22] Improve ParDoEvaluator Factoring

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This moves shared code into a common location.
    Clone DoFn instances before constructing the DoFnRunner to
     avoid races.

You can merge this pull request into a Git repository by running:

    $ git pull ippr_better_ParDoEvaluator_factoring

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #188
commit ecc26d51cee4ea1568948d48cd3441594f638e39
Author: Thomas Groh <>
Date:   2016-03-30T00:38:22Z

    Move Shared construction code to ParDoInProcessEvaluator
    Remove duplicate code in ParDo(Single/Multi)EvaluatorFactory; instead
    only extract the appropriate elements and pass them to the
    ParDoInProcessEvaluator.t log

commit e47aba0a7097cee8341369594e47e73b83029a50
Author: Thomas Groh <>
Date:   2016-04-15T17:23:15Z

    Clone DoFns before constructing a DoFnRunner
    This ensures that each thread gets an individual copy of a DoFn, so
    multiple threads do not interact.


> DirectPipelineRunner: support for unbounded collections
> -------------------------------------------------------
>                 Key: BEAM-22
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-direct
>            Reporter: Davor Bonaci
>            Assignee: Thomas Groh
> DirectPipelineRunner currently runs over bounded PCollections only, and implements only
a portion of the Beam Model.
> We should improve it to faithfully implement the full Beam Model, such as add ability
to run over unbounded PCollections, and better resemble execution model in a distributed system.
> This further enables features such as a testing source which may simulate late data and
test triggers in the pipeline. Finally, we may want to expose an option to select between
"debug" (single threaded), "chaos monkey" (test as many model requirements as possible), and
"performance" (multi-threaded).
> more testing (chaos monkey) 
> Once this is done, we should update this StackOverflow question:

This message was sent by Atlassian JIRA

View raw message