beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-38) Avoid repeated DoFn deserialization
Date Tue, 07 Jun 2016 22:09:21 GMT

    [ https://issues.apache.org/jira/browse/BEAM-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319555#comment-15319555
] 

ASF GitHub Bot commented on BEAM-38:
------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/429

    [BEAM-38] Reset Writer in WriteBundles.finishBundle

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This allows the WriteBundles DoFn to be reused.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam reset_write_bundles_state

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #429
    
----
commit 41a3ec65fc2f6465b58b1f5bc768276788c71978
Author: Thomas Groh <tgroh@google.com>
Date:   2016-06-07T21:52:20Z

    Reset Writer in WriteBundles.finishBundle
    
    This allows the WriteBundles DoFn to be reused.

----


> Avoid repeated DoFn deserialization
> -----------------------------------
>
>                 Key: BEAM-38
>                 URL: https://issues.apache.org/jira/browse/BEAM-38
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>
> Alluded to in our technical vision, we wish to remove at least some guarantees about
when a fresh DoFn instance is created. Repeated deserialization can become a major cost when
bundles are very small, as in some streaming pipelines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message