beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-38) Avoid repeated DoFn deserialization
Date Mon, 06 Jun 2016 18:57:21 GMT

    [ https://issues.apache.org/jira/browse/BEAM-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316987#comment-15316987
] 

ASF GitHub Bot commented on BEAM-38:
------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/419

    [BEAM-38] Allow DoFns to be Reused

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Modify the documentation of ParDo to allow DoFns to be reused for
    multiple bundles in the general case. This allows DoFns which implement
    start and finish bundle to be reused.
    
    Update ParDoTest.TestDoFn to succeed if reused.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam do_fn_reuse

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/419.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #419
    
----
commit 5e60c70a93cdc0855f51681c1fa1724380f7661a
Author: Thomas Groh <tgroh@google.com>
Date:   2016-06-06T18:52:58Z

    Allow DoFns to be Reused
    
    Modify the documentation of ParDo to allow DoFns to be reused for
    multiple bundles in the general case. This allows DoFns which implement
    start and finish bundle to be reused.
    
    Update ParDoTest.TestDoFn to succeed if reused.

----


> Avoid repeated DoFn deserialization
> -----------------------------------
>
>                 Key: BEAM-38
>                 URL: https://issues.apache.org/jira/browse/BEAM-38
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>
> Alluded to in our technical vision, we wish to remove at least some guarantees about
when a fresh DoFn instance is created. Repeated deserialization can become a major cost when
bundles are very small, as in some streaming pipelines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message