beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-243) Remove DirectPipelineRunner and keep only the InProcessPipelineRunner
Date Wed, 15 Jun 2016 01:25:30 GMT

    [ https://issues.apache.org/jira/browse/BEAM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330974#comment-15330974
] 

ASF GitHub Bot commented on BEAM-243:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/466

    [BEAM-243] Remove the DirectPipelineRunner from the Core SDK

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam rm_direct_runner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #466
    
----
commit 4da5ebfbf021051288620634ec84cafa9208265c
Author: Thomas Groh <tgroh@google.com>
Date:   2016-06-14T20:39:59Z

    Use TimestampedValue in DoFnTester
    
    This removes the duplicate OutputElementWithTimestamp data structure.

commit 3ffc763a231e4b523f220aa6e05aad5c873cc4c7
Author: Thomas Groh <tgroh@google.com>
Date:   2016-06-14T20:18:41Z

    Add DoFnTester#peekOutputValuesInWindow
    
    This permits DoFns that interact with windowing to test the windowed,
    rather than overall output.

commit 8d01ae255aa8ec581e923294042c29866cfedfd8
Author: Thomas Groh <tgroh@google.com>
Date:   2016-06-15T00:51:48Z

    Remove DoFnRunner from GroupAlsoByWindowsProperties
    
    DoFnRunner is a runner implementation detail, and core SDK code should
    instead use DoFnTester.

commit c88bf988f5ed3c954ae957ea01b6f1b752815418
Author: Thomas Groh <tgroh@google.com>
Date:   2016-06-15T00:52:49Z

    Remove the DirectPipelineRunner from the Core SDK

----


> Remove DirectPipelineRunner and keep only the InProcessPipelineRunner
> ---------------------------------------------------------------------
>
>                 Key: BEAM-243
>                 URL: https://issues.apache.org/jira/browse/BEAM-243
>             Project: Beam
>          Issue Type: Task
>          Components: runner-direct
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Thomas Groh
>
> We have two runners for local JVM/process: the "old" DirectPipelineRunner and the "new"
InProcessPipelineRunner.
> They have different feature (for instance the DirectPipelineRunner doesn't support Unbounded
PCollection, whereas InProcessPipelineRunner does).
> To avoid confusion, we could remove the "old" DirectPipelineRunner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message