beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swegner <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #441: [BEAM-331] Make AddTimestampFn range deter...
Date Thu, 09 Jun 2016 18:33:03 GMT
GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/441

    [BEAM-331] Make AddTimestampFn range deterministic

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The timestamps added in the WindowedWordCount example are currently
    based on when the bundles are executed, which makes the min/max bounds
    non-deterministic. This change makes the range  based on the
    construction time.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam wwc-addtimestampfn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #441
    
----
commit 6b1d3a7d5a4e2bb9ecb010102a7d0506cda15986
Author: Scott Wegner <swegner@google.com>
Date:   2016-06-09T18:31:23Z

    Make AddTimestampFn range deterministic
    
    The timestamps added in the WindowedWordCount example are currently
    based on when the bundles are executed, which makes the min/max bounds
    non-deterministic. This change makes the range  based on the
    construction time.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message