beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmannibucau <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #496: [BEAM-357] fixing build on windows
Date Sun, 19 Jun 2016 19:21:48 GMT
GitHub user rmannibucau opened a pull request:

    https://github.com/apache/incubator-beam/pull/496

    [BEAM-357] fixing build on windows

    Small fixes or workarounds for windows.
    
    Main issues were:
    
    - Paths.get(...): windows has ":" which will make it failing, using new File(...).toPath()
to fix it
    - Workaround for hadoop which requires winutils.exe on windows (see https://issues.apache.org/jira/browse/BEAM-357
for a comment on it)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmannibucau/incubator-beam BEAM-357_windows-build-fails

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #496
    
----
commit 418833001fe6dd581f42f7fcc3c35ef36f292007
Author: Romain manni-Bucau <rmannibucau@gmail.com>
Date:   2016-06-19T19:19:57Z

    fixing build on windows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message