beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmannibucau <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #519: avoid to fail cause of \r of windows on EO...
Date Wed, 22 Jun 2016 08:45:09 GMT
GitHub user rmannibucau opened a pull request:

    https://github.com/apache/incubator-beam/pull/519

    avoid to fail cause of \r of windows on EOL + fixing copyOne from Fil…

    Lighter version of https://github.com/apache/incubator-beam/pull/496 (basically removed
the hadoop workaround)
    
    Build doesn't fully pass out of the box (= without setting up hadoop locally) but it doesn't
fail for simple issues like EOL differences.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmannibucau/incubator-beam BEAM-357_path-handling-fails-on-windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/519.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #519
    
----
commit 2d3c9fee013c04fbad7013c3e334a5fae73aa53b
Author: Romain manni-Bucau <rmannibucau@gmail.com>
Date:   2016-06-22T08:42:45Z

    avoid to fail cause of \r of windows on EOL + fixing copyOne from FileBasedSink which
fails on windows hardrive syntax (colon) and avoid to have issues cause a folder can't be
deleted in WriteSinkITCase - easily happen on windows cause of locking mecanism

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message