beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #523: [BEAM-191] Make WindowedValue extendable a...
Date Thu, 23 Jun 2016 20:28:32 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/523

    [BEAM-191] Make WindowedValue extendable and deprecated valueInEmptyWindows

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam WindowedValue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/523.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #523
    
----
commit 313ac286850a974862e815c6356c0ff5e37284cd
Author: Kenneth Knowles <klk@google.com>
Date:   2016-06-22T14:28:34Z

    Allow other subclasses of WindowedValue

commit 20a8e96bc705fc9554fef735312df15b3c57588a
Author: Kenneth Knowles <klk@google.com>
Date:   2016-06-22T14:40:38Z

    Make WindowedValue like an interface, allow external implementations

commit 33614c93bc2c41225d8696c94fb917be65d3f3a7
Author: Kenneth Knowles <klk@google.com>
Date:   2016-06-22T14:44:45Z

    Deprecate WindowedValue.valueInEmptyWindows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message