beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #527: [BEAM-155] Use only WindowFn in TriggerTes...
Date Fri, 24 Jun 2016 04:33:30 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/527

    [BEAM-155] Use only WindowFn in TriggerTester

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This change is preparatory for separating trigger syntax from implementation.
    
    Previously, the whole `WindowingStrategy` was passed in, but not used. Since the tester
is really a test of the state machine, it will be moved to runners-core alongside the trigger
implementation. The requirement to provide a `WindowingStrategy` with the original syntax
is extraneous.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam TriggerTester

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/527.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #527
    
----
commit 2cdc2be45cd7722232b56e8fdef5670b33c337d8
Author: Kenneth Knowles <klk@google.com>
Date:   2016-06-24T04:24:22Z

    Use only WindowFn in TriggerTester
    
    This change is preparatory for separating trigger syntax
    from implementation.
    
    Previously, the whole WindowingStrategy was passed in, but
    not used. Since the tester is really a test of the state
    machine, it will be moved to runners-core alongside the trigger
    implementation. The requirement to provide a WindowingStrategy
    with the original syntax is extraneous.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message