beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #528: [BEAM-155] Remove TriggerBuilder backwards...
Date Fri, 24 Jun 2016 04:34:24 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-155] Remove TriggerBuilder backwards-compatibility adapter

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This is preparatory work to make it easier to separate trigger syntax from implementation.

You can merge this pull request into a Git repository by running:

    $ git pull TriggerBuilder

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #528
commit 244e8e85596c944b23e37e59a717be314c496f74
Author: Kenneth Knowles <>
Date:   2016-06-24T04:03:29Z

    Remove TriggerBuilder backwards-compatibility adapter


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message