beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-338) Fix licensing and usage of gutenberg files in Spark test
Date Sun, 03 Jul 2016 20:23:10 GMT


ASF GitHub Bot commented on BEAM-338:

GitHub user jbonofre opened a pull request:

    [BEAM-338] Cleanup Spark runner test resources to avoid notice update

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Cleanup Spark runner test resources to avoid NOTICE & LICENSE update.

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-338

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #586
commit c81332e264c827a35c8c16a4f227e7c4837d1085
Author: Jean-Baptiste Onofré <>
Date:   2016-07-03T20:20:27Z

    [BEAM-338] Cleanup Spark runner test resources to avoid notice update


> Fix licensing and usage of gutenberg files in Spark test
> --------------------------------------------------------
>                 Key: BEAM-338
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: project-management, runner-spark
>    Affects Versions: 0.1.0-incubating
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 0.2.0-incubating
> Spark runner tests use couple of Gutenberg files:
> {code}
> runners/spark/src/test/resources/pg1112.txt
> runners/spark/src/test/resources/pg2264.txt
> {code}
> At least, the LICENSE file should mention these resources. However, as the Project Gutenberg
license is not listed in Apache license categories, we have to ask to legal.
> In order to simplify our NOTICE file, and avoid any legal concerns, I propose to replace
the {{pg*}} Spark test resources with another kind of resources for the test (handmade for

This message was sent by Atlassian JIRA

View raw message