beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-408) ProxyInvocationHandler uses inefficient Math.random() for random int
Date Mon, 04 Jul 2016 22:51:10 GMT

    [ https://issues.apache.org/jira/browse/BEAM-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361814#comment-15361814
] 

ASF GitHub Bot commented on BEAM-408:
-------------------------------------

GitHub user lucasallan opened a pull request:

    https://github.com/apache/incubator-beam/pull/588

    [BEAM-408] - Fixes ProxyInvocationHandler uses inefficient Math.random() for random int

    For more information: https://issues.apache.org/jira/browse/BEAM-408

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lucasallan/incubator-beam beam-408

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/588.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #588
    
----
commit 2196b3c7dd7d4da660df672f7f6568fcd3d4eb93
Author: Lucas Amorim <lucasamorim@protonmail.com>
Date:   2016-07-04T22:47:39Z

    [BEAM-408] - Fixes ProxyInvocationHandler uses inefficient Math.random() for random int
    
    For more information: https://issues.apache.org/jira/browse/BEAM-408

----


> ProxyInvocationHandler uses inefficient Math.random() for random int
> --------------------------------------------------------------------
>
>                 Key: BEAM-408
>                 URL: https://issues.apache.org/jira/browse/BEAM-408
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>
> [FindBugs DM_NEXTINT_VIA_NEXTDOUBLE|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L209]:
Use the nextInt method of Random rather than nextDouble to generate a random integer
> Applies to: [ProxyInvocationHandler.hashCode|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ProxyInvocationHandler.java#L96].
This random value is used as a pseudo-unique value for #hashCode(), although the default Object.hasCode()
implementation does the same thing, so this should be unnecessary.
> This is a good starter bug. When fixing, please remove the corresponding entries from
[findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message