beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-401) StandardCoder uses inefficient string concatenation
Date Thu, 04 Aug 2016 19:02:20 GMT


ASF GitHub Bot commented on BEAM-401:

GitHub user chandnisingh opened a pull request:

    BEAM-401 used StringBuilder in toString of StandardCoder

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-401

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #789
commit 5734fdfd571e8d6063678439da628918b680e21f
Author: Chandni Singh <>
Date:   2016-08-04T19:00:41Z

    BEAM-401 used StringBuilder in toString of StandardCoder


> StandardCoder uses inefficient string concatenation
> ---------------------------------------------------
>                 Key: BEAM-401
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Assignee: Chandni Singh
>            Priority: Minor
>              Labels: findbugs, newbie, starter
Method invokes inefficient new String(String) constructor
> Applies to: [StandardCoder.toString|].
> This is a good starter bug. When fixing, please remove the corresponding entries from
and verify the build passes.

This message was sent by Atlassian JIRA

View raw message