beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmet Altay (JIRA)" <>
Subject [jira] [Created] (BEAM-520) Update Python SDK example tests to use assert_that
Date Wed, 03 Aug 2016 01:36:20 GMT
Ahmet Altay created BEAM-520:

             Summary: Update Python SDK example tests to use assert_that
                 Key: BEAM-520
             Project: Beam
          Issue Type: Improvement
          Components: sdk-py
            Reporter: Ahmet Altay
            Priority: Minor

Most of our examples use assert_that to test examples:

Some of our examples use this pattern:

1) Create a path(s)
2) Construct fake command line arguments using these paths
3) Construct an argparse object to parse these flags
4) Do the (often trivial logic)
5) Write to a file
6) Manually open and read the file
7) Compare results.

As well as being cumbersome, this obscures the core of what is being illustrated and tested.
As many as possible tests should be updated to use assert_that.

This message was sent by Atlassian JIRA

View raw message