beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #777: Bind checkstyle:check to the test-compile ...
Date Wed, 03 Aug 2016 23:13:54 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/777

    Bind checkstyle:check to the test-compile phase to fail earlier

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Today we run checkstyle _after packaging_ so we have to wait for all the various jars
to be built before we fail.
    
    This change binds checkstyle to the earliest phase that seems reasonable.
    
    R: anyone

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam checkstyle-earlier

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #777
    
----
commit 1fecb2844c0b7e6cdedb93d93164d2151c847f98
Author: Kenneth Knowles <klk@google.com>
Date:   2016-08-03T23:12:15Z

    Bind checkstyle:check to the test-compile phase to fail earlier

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message