beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vikkyrk <>
Subject [GitHub] incubator-beam pull request #833: [BEAM-550] DatastoreIO Sink as ParDo
Date Mon, 15 Aug 2016 22:44:56 GMT
GitHub user vikkyrk opened a pull request:

    [BEAM-550] DatastoreIO Sink as ParDo

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    - DatastoreIO doesn't have an atomic operations, making WriteOperation#(initialize/finalize)
a noop. There is no benefit for the additional complexity the Sink API brings. Hence cleaning
up those classes and directly using a ParDo to implement Datastore writes.

You can merge this pull request into a Git repository by running:

    $ git pull vikasrk/datastore_sink

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #833
commit 3ad876dddbf3affe39093a748578aa5d93f7b4e0
Author: Vikas Kedigehalli <>
Date:   2016-08-15T22:28:07Z

    DatastoreIO Sink as ParDo


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message