beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Bradshaw (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-517) Check versions of pip and cython
Date Mon, 26 Sep 2016 19:33:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523965#comment-15523965
] 

Robert Bradshaw commented on BEAM-517:
--------------------------------------

+1, please file a PR

I don't think we rely on any recent version of Cython, maybe just ask for 0.23.2 (released
just over a year ago). Might also be worth using distutils.version for comparisons. 

> Check versions of pip and cython
> --------------------------------
>
>                 Key: BEAM-517
>                 URL: https://issues.apache.org/jira/browse/BEAM-517
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Priority: Minor
>              Labels: starter
>
> Python SDK depends on pip and cython however it does not check the versions of these.
> Some of the pip flags does not exist in older versions:
> https://github.com/GoogleCloudPlatform/DataflowPythonSDK/issues/28#issuecomment-236382953
> (Note: Even though the above issue was reported by the user in a different repo it is
related to the apache beam sdk)
> Similarly with cython, SDK supports running with or without Cython. Because of that reason
it is not list it as a requirement in the setup.py file. However, with an old version of cython
SDK might fail.
> To avoid the above problem: In the SDK check the version of these packages and show a
warning to upgrade.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message