beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aljoscha Krettek (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-644) Primitive to shift the watermark while assigning timestamps
Date Thu, 22 Sep 2016 08:20:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512585#comment-15512585
] 

Aljoscha Krettek commented on BEAM-644:
---------------------------------------

Doesn't a shift by {{D}} just shift (hehe, yes) the problem by a bit but in the end you still
don't know what timestamps future data might have?

> Primitive to shift the watermark while assigning timestamps
> -----------------------------------------------------------
>
>                 Key: BEAM-644
>                 URL: https://issues.apache.org/jira/browse/BEAM-644
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> There is a general need, especially important in the presence of SplittableDoFn, to be
able to assign new timestamps to elements without making them late or droppable.
>  - DoFn.withAllowedTimestampSkew is inadequate, because it simply allows one to produce
late data, but does not allow one to shift the watermark so the new data is on-time.
>  - For a SplittableDoFn, one may receive an element such as the name of a log file that
contains elements for the day preceding the log file. The timestamp on the filename must currently
be the beginning of the log. If such elements are constantly flowing, it may be OK, but since
we don't know that element is coming, in that absence of data, the watermark may advance.
We need a way to keep it far enough back even in the absence of data holding it back.
> One idea is a new primitive ShiftWatermark / AdjustTimestamps with the following pieces:
>  - A constant duration (positive or negative) D by which to shift the watermark.
>  - A function from TimestampedElement<T> to new timestamp that always falls within
D of the original timestamp.
> With this primitive added, outputWithTimestamp and withAllowedTimestampSkew could be
removed, simplifying DoFn.
> Alternatively, all of this functionality could be bolted on to DoFn.
> This ticket is not a proposal, but a record of the issue and ideas that were mentioned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message