beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-670) BigQuery TableRow inserter incorrectly handles nextBackOff millis
Date Tue, 27 Sep 2016 17:50:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526915#comment-15526915
] 

ASF GitHub Bot commented on BEAM-670:
-------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/incubator-beam/pull/1018

    [BEAM-670] BigQueryServicesImpl: fix issues in insertAll and add better tests

    R: @lukecwik
    CC: @vikkyrk 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/incubator-beam bigquery-tableinserter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1018.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1018
    
----
commit 3581a4e1a67fcb37cdfe5fec8e7973fbad3617d5
Author: Dan Halperin <dhalperi@google.com>
Date:   2016-09-27T17:47:07Z

    BigQueryServicesImpl: fix issues in insertAll and add better tests

----


> BigQuery TableRow inserter incorrectly handles nextBackOff millis
> -----------------------------------------------------------------
>
>                 Key: BEAM-670
>                 URL: https://issues.apache.org/jira/browse/BEAM-670
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp
>            Reporter: Luke Cwik
>            Assignee: Daniel Halperin
>            Priority: Minor
>
> From:
> https://github.com/GoogleCloudPlatform/DataflowJavaSDK/commit/94d57207924ed8650cf3c97fccb2a45f27bcc6a3#commitcomment-19135952
> Also present in:
> https://github.com/apache/incubator-beam/pull/888/files#diff-f6d45f28c12083c9556bb410bde8b109R614
> The check is inverted, it should be nextBackoffMillis != BackOff.STOP
> Otherwise it causes Thread.sleep() to be called with value -1 which causes an IllegalArgumentException
exception to be thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message