beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-733) Windowed side-inputs not supported in Python
Date Fri, 07 Oct 2016 23:33:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556611#comment-15556611
] 

ASF GitHub Bot commented on BEAM-733:
-------------------------------------

GitHub user robertwb opened a pull request:

    https://github.com/apache/incubator-beam/pull/1070

    [BEAM-733] Prohibit windowed side inputs until they are implemented correctly.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertwb/incubator-beam side-inputs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1070.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1070
    
----
commit 5b8e7685b5d5582e894b726ce0189c76199f0b7a
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2016-10-07T22:28:50Z

    Dissallow (unimplemented) windowed side inputs.

commit fa079b99fcf300dc210d21020f821a88b6142b79
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2016-10-07T23:17:47Z

    Fix tests.

commit e10587b162944475290581dc8bb35dfec4cf0afd
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2016-10-07T23:31:20Z

    Add windowed side inputs failure test.

----


> Windowed side-inputs not supported in Python
> --------------------------------------------
>
>                 Key: BEAM-733
>                 URL: https://issues.apache.org/jira/browse/BEAM-733
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message