beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Baptiste Onofré (JIRA) <j...@apache.org>
Subject [jira] [Resolved] (BEAM-743) JdbcIO should not use getConnection() with username and password when using DBCP BasicDataSource
Date Wed, 19 Oct 2016 06:14:59 GMT

     [ https://issues.apache.org/jira/browse/BEAM-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jean-Baptiste Onofré resolved BEAM-743.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.3.0-incubating

> JdbcIO should not use getConnection() with username and password when using DBCP BasicDataSource
> ------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-743
>                 URL: https://issues.apache.org/jira/browse/BEAM-743
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 0.3.0-incubating
>
>
> When we use an username and password, {{JdbcIO}} uses {{dataSource.getConnection(username,
password)}}.
> However, this method is not supported by DBCP {{BasicDataSource}} (as the username and
password are already part of the data source).
> Basically, the test should be if username is not null and if datasource (user provided)
is not null, then we use {{getConnection(username, password)}} else, we just use {{getConnection()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message