beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-755) beam-runners-core-java NeedsRunner tests not executing
Date Thu, 20 Oct 2016 02:31:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590545#comment-15590545
] 

ASF GitHub Bot commented on BEAM-755:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1140

    [BEAM-755] Fix typo and dependencies in beam-runners-direct-java

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Just fixing the typo and deps to run the tests in the same manner that others currently
run.
    
    R: @tgroh @lukecwik 
    
    Confirmed that `mvn clean verify -pl runners/direct-java/ -am` does run `org.apache.beam.runners.core.UnboundedReadFromBoundedSourceTest`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam DirectRunner-typo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1140
    
----
commit 9ae68a418709f1cd97416865c5de0fb11d99847e
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-20T02:26:35Z

    Fix typo and dependencies in beam-runners-direct-java

----


> beam-runners-core-java NeedsRunner tests not executing
> ------------------------------------------------------
>
>                 Key: BEAM-755
>                 URL: https://issues.apache.org/jira/browse/BEAM-755
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Luke Cwik
>            Assignee: Kenneth Knowles
>            Priority: Minor
>             Fix For: 0.3.0-incubating
>
>
> org.apache.beam:beam-runners-core-java is not specified as an integration test dependency
to scan within runners/pom.xml
> There is also in runners/direct-java/pom.xml where its org.apache.beam:beam-runners-java-core
and should be org.apache.beam:beam-runners-core-java
> Finally, even if these dependencies are added and the typo fixed. When running the runnable
on service integration tests, SplittableParDoTest which contains @RunnableOnService tests
(part of runners/core-java) doesn't execute.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message