beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1080: [BEAM-498] Inline DoFnRunnerBase and fix ...
Date Mon, 10 Oct 2016 22:07:51 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1080

    [BEAM-498] Inline DoFnRunnerBase and fix up

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This class had just one subclass and cleaning up these little bits makes it clearer as
we move to the new `DoFn`. Nothing radical, but I need to make `DoFnRunners` work with old
and new `DoFn` so each dangling class just adds complexity to the field of operation.
    
    R: @peihe

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam OldDoFnRunner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1080.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1080
    
----
commit 2848f8b8f4203fb6dde319779852d57aa98dac4d
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-10T21:59:54Z

    Remove unused ListOutputManager

commit 249d2d970039f5b096da7f9306acdfc41a817ee1
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-10T22:01:41Z

    Inline DoFnRunnerBase to its sole subclass

commit b5b28517e8f9cf1394bfc09ec7dfecf8c3d3c048
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-10T22:04:42Z

    Fix access levels on SimpleDoFnRunner

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message