beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1098: [BEAM-596] Replace DirectResult#awaitComp...
Date Thu, 13 Oct 2016 22:09:25 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1098

    [BEAM-596] Replace DirectResult#awaitCompletion with waitUntilFinish

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This is the PipelineResult interface method, rather than the
    DirectRunner-specific method.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam wait_until_finsish

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1098.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1098
    
----
commit 851b447584015e9e0e864554d1ba507f09157eb8
Author: Thomas Groh <tgroh@google.com>
Date:   2016-10-13T22:07:51Z

    Replace DirectResult#awaitCompletion with waitUntilFinish
    
    This is the PipelineResult interface method, rather than the
    DirectRunner-specific method.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message